From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 2.6]: ip6t_{hbh,dst}: Rejects not-strict mode on rule insersion Date: Tue, 09 Sep 2008 08:54:00 +0200 Message-ID: <48C61D88.6050703@trash.net> References: <200809080613.m886DnGY021233@toshiba.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Yasuyuki KOZAKAI Return-path: Received: from stinky.trash.net ([213.144.137.162]:63712 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751785AbYIIGyD (ORCPT ); Tue, 9 Sep 2008 02:54:03 -0400 In-Reply-To: <200809080613.m886DnGY021233@toshiba.co.jp> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Yasuyuki KOZAKAI wrote: > Hi Patrick, > > Please apply the following patch. The option IP6T_OPTS_NSTRICT causes to > ignore rules for options in HBH/DST header. > > I think this issue affects few users. Because fortunately (?) man page and > 'ip6tables -m hbh --help' does not show --hbh-not-strict option, and > 'ip6tables ... --hbh-not-strict' does not work due to incorrect has_arg > value in userland libip6t_hbh.c ;) > > I will implement not-strict mode, so the patch leaves the definition of > IP6T_OPTS_NSTRICT. The strict mode is too strict (the specified options > have to be included in order in HBH/DST header) and would be useless > in most senarios. Since my knowledge of this quite limited - is this fix important enough so it should go in 2.6.27, or is queuing it for 2.6.28 OK too?