Re: Alignment problem with ebt_among

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> On Wednesday 2008-09-10 10:23, Patrick McHardy wrote:
>>> but this of course breaks the binary interface between userspace and
>>> kernel. Possible solutions I can think of:
>>>
>>>  (a) kill ebt_among
>>>  (b) willingly change it and break ABI
>>>  (c) continue planned transformation to Xtables and fix later
>>>
>>> Which should it be?
>> How about:
>>
>> (d) add compat support to ebtables, transform to xtables,
>>    add compat translation
> 
> That's the same as (c) for me ;-)
> except that the order is slightly different -- I think the patches
> would also be smaller if we went for Xtables first, because its
> structs at least already have the compat members, for example.

Thats true, its easier to do it the other way around since
you don't have to add compat support to ebtables while its
still standalone, just to delete it in following patches
again.

OTOH, 99% of the core compat support is contained in the
*_tables files anyway, so the difference should be very small.
If you take the route I asked you to, namely first making
ebtables and xtables structs and return conventions match
before doing the actual conversion to use the x_tables
infrastructure, you could already use the compat helpers.
This should result in a fully bisectable set of changes.