From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Jesper Bengtsson <jesper.bengtsson@axis.com>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] Fix ERROR target on CRIS
Date: Thu, 16 Oct 2008 14:07:23 +0200 [thread overview]
Message-ID: <48F72E7B.7090001@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0810151544580.10924@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
>> struct ipt_error_target
>> {
>> struct ipt_entry_target target;
>> - char errorname[IPT_FUNCTION_MAXNAMELEN];
>> + char errorname[IPT_TABLE_MAXNAMELEN];
>
> Resolve the indirect macro - use XT_TABLE_MAXNAMELEN.
Thats also fine of course.
> Fix up IPv6 too?
> This looks not quite right to me though it is of course one way
> to achieve to goal.. How about this?:
>
> char errorname[XT_ALIGN(XT_FUNCTION_MAXNAMELEN)]
>
> is what I would suggest.
That misses the point, CRIS doesn't require any alignment and
FUNCTION_MAXNAMELEN is wrong here.
next prev parent reply other threads:[~2008-10-16 12:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <A612847CFE53224C91B23E3A5B48BAC73889D09813@xmail3.se.axis.com>
2008-10-15 19:43 ` [PATCH] Fix ERROR target on CRIS Jesper Bengtsson
2008-10-15 19:49 ` Jan Engelhardt
2008-10-16 11:28 ` Jesper Bengtsson
2008-10-16 16:12 ` Jan Engelhardt
2008-10-16 12:07 ` Patrick McHardy [this message]
2008-10-16 12:06 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F72E7B.7090001@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=jesper.bengtsson@axis.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox