From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 7/8] [PATCH] dynamic calculation of event message size for ctnetlink Date: Tue, 18 Nov 2008 11:21:46 +0100 Message-ID: <4922973A.7000001@netfilter.org> References: <20081117083924.11368.38741.stgit@Decadence> <20081117084141.11368.26975.stgit@Decadence> <49218EA3.8090801@trash.net> <49223799.70505@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Patrick McHardy Return-path: Received: from mail.us.es ([193.147.175.20]:59878 "EHLO us.es" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751709AbYKRKWA (ORCPT ); Tue, 18 Nov 2008 05:22:00 -0500 In-Reply-To: <49223799.70505@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Pablo Neira Ayuso wrote: > Patrick McHardy wrote: >> These calculations look somewhat expensive to perform for every message. >> Do you have any numbers for this new patch that shows the difference >> in CPU usage compared to the resizing done by af_netlink.c? > > Fabian Hugelshofer reported some reduction (~5%) on an embedded > environment but he was using top to measure the difference. I'll collect > some more trustable data and get back to you. Some oprofile results: wo/patch 2189 0.0305 nf_conntrack_netlink.ko nf_conntrack_netlink ctnetlink_conntrack_event w/patch 2302 0.0440 nf_conntrack_netlink.ko nf_conntrack_netlink ctnetlink_conntrack_event While __alloc_skb and netlink_broadcast report similar values for w/ and wo/ the patch. -- "Los honestos son inadaptados sociales" -- Les Luthiers