netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Phil Oester <kernel@linuxace.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Shane Goulden <shane@matrixau.net>,
	netfilter-devel@vger.kernel.org
Subject: Re: ip_conntrack_ftp messages
Date: Mon, 24 Nov 2008 16:32:41 +0100	[thread overview]
Message-ID: <492AC919.7070005@trash.net> (raw)
In-Reply-To: <20081124152458.GA20442@linuxace.com>

Phil Oester wrote:
> On Mon, Nov 24, 2008 at 01:28:09PM +0100, Patrick McHardy wrote:
>> Rusty Russell wrote:
>>> On Monday 24 November 2008 10:43:19 Shane Goulden wrote:
>>>> 2.6.18-92.1.10.el5xen
>>>>
>>>> FTP is working. Is there a way to easily silence the messages?
>>> Not that I am aware of.  Perhaps that printk (still there in latest 
>>> kernels) should be downgraded to a DEBUG?
>>>
>> Its strange that FTP is apparently working since we drop those packets.
>> I'm not sure about downgrading that message, its there to inform the
>> user of an exceptional action (dropping of packets within conntrack).
>>
>> Shane, how do you trigger those messages?
> 
> I've seen these messages when something other than FTP is utilizing
> port 21.  Perhaps we should have a bit in the conntrack helper which
> stops looking on future packets if it doesn't see FTP traffic in the
> beginning of the session?

That would make sense, but I can't see a good way to make this
decision except maybe when we seen non-ascii characters. But
even that will fail with different encodings. Do you have a
good idea?



  reply	other threads:[~2008-11-24 15:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <31563483.01227485595724.JavaMail.shane@shane-laptop>
2008-11-24  4:15 ` ip_conntrack_ftp messages Rusty Russell
2008-11-24 12:28   ` Patrick McHardy
2008-11-24 15:24     ` Phil Oester
2008-11-24 15:32       ` Patrick McHardy [this message]
2008-11-24 15:54         ` Jan Engelhardt
2008-11-24 16:08           ` Patrick McHardy
2008-11-24 16:23           ` Pascal Hambourg
2008-11-24 17:14     ` Rusty Russell
2008-11-24 17:34       ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=492AC919.7070005@trash.net \
    --to=kaber@trash.net \
    --cc=kernel@linuxace.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=shane@matrixau.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).