From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Phil Oester <kernel@linuxace.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Shane Goulden <shane@matrixau.net>,
netfilter-devel@vger.kernel.org
Subject: Re: ip_conntrack_ftp messages
Date: Mon, 24 Nov 2008 17:08:36 +0100 [thread overview]
Message-ID: <492AD184.1050403@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0811241653370.15363@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Monday 2008-11-24 16:32, Patrick McHardy wrote:
>>> I've seen these messages when something other than FTP is utilizing
>>> port 21. Perhaps we should have a bit in the conntrack helper which
>>> stops looking on future packets if it doesn't see FTP traffic in the
>>> beginning of the session?
>> That would make sense, but I can't see a good way to make this
>> decision except maybe when we seen non-ascii characters. But
>> even that will fail with different encodings. Do you have a
>> good idea?
>
> Well, each packet (or rather, every new line) should be a "123 " code,
> followed by whatever text plus a newline.
Right, that should work. If someone wants to cook up a patch,
I have no objections :)
next prev parent reply other threads:[~2008-11-24 16:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <31563483.01227485595724.JavaMail.shane@shane-laptop>
2008-11-24 4:15 ` ip_conntrack_ftp messages Rusty Russell
2008-11-24 12:28 ` Patrick McHardy
2008-11-24 15:24 ` Phil Oester
2008-11-24 15:32 ` Patrick McHardy
2008-11-24 15:54 ` Jan Engelhardt
2008-11-24 16:08 ` Patrick McHardy [this message]
2008-11-24 16:23 ` Pascal Hambourg
2008-11-24 17:14 ` Rusty Russell
2008-11-24 17:34 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492AD184.1050403@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=shane@matrixau.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).