From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: ctnetlink: fix missing CTA_NAT_SEQ_UNSPEC
Date: Thu, 11 Dec 2008 14:00:47 +0100 [thread overview]
Message-ID: <49410EFF.1020603@trash.net> (raw)
In-Reply-To: <20081210200649.23169.33618.stgit@Decadence>
Pablo Neira Ayuso wrote:
> This patch fixes an inconsistency in nfnetlink_conntrack.h that
> I introduced myself. The problem is that CTA_NAT_SEQ_UNSPEC is
> missing from enum ctattr_natseq. This inconsistency may lead to
> problems in the message parsing in userspace (if the message
> contains the CTA_NAT_SEQ_* attributes, of course).
>
> This patch breaks backward compatibility, however, the only known
> client of this code is libnetfilter_conntrack which indeed crashes
> because it assumes the existence of CTA_NAT_SEQ_UNSPEC to do
> the parsing.
>
> The CTA_NAT_SEQ_* attributes were introduced in 2.6.25.
Applied, thanks.
next prev parent reply other threads:[~2008-12-11 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 20:06 [PATCH] netfilter: ctnetlink: fix missing CTA_NAT_SEQ_UNSPEC Pablo Neira Ayuso
2008-12-11 13:00 ` Patrick McHardy [this message]
2008-12-11 21:44 ` Pablo Neira Ayuso
2008-12-15 12:12 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49410EFF.1020603@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).