[PATCH] netfilter: ctnetlink: fix missing CTA_NAT_SEQ_UNSPEC

[PATCH] netfilter: ctnetlink: fix missing CTA_NAT_SEQ_UNSPEC

[Pablo Neira Ayuso]

This patch fixes an inconsistency in nfnetlink_conntrack.h that
I introduced myself. The problem is that CTA_NAT_SEQ_UNSPEC is
missing from enum ctattr_natseq. This inconsistency may lead to
problems in the message parsing in userspace (if the message
contains the CTA_NAT_SEQ_* attributes, of course).

This patch breaks backward compatibility, however, the only known
client of this code is libnetfilter_conntrack which indeed crashes
because it assumes the existence of CTA_NAT_SEQ_UNSPEC to do
the parsing.

The CTA_NAT_SEQ_* attributes were introduced in 2.6.25.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

 include/linux/netfilter/nfnetlink_conntrack.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/netfilter/nfnetlink_conntrack.h b/include/linux/netfilter/nfnetlink_conntrack.h
index c19595c..29fe9ea 100644
--- a/include/linux/netfilter/nfnetlink_conntrack.h
+++ b/include/linux/netfilter/nfnetlink_conntrack.h
@@ -141,6 +141,7 @@ enum ctattr_protonat {
 #define CTA_PROTONAT_MAX (__CTA_PROTONAT_MAX - 1)
 
 enum ctattr_natseq {
+	CTA_NAT_SEQ_UNSPEC,
 	CTA_NAT_SEQ_CORRECTION_POS,
 	CTA_NAT_SEQ_OFFSET_BEFORE,
 	CTA_NAT_SEQ_OFFSET_AFTER,

Re: [PATCH] netfilter: ctnetlink: fix missing CTA_NAT_SEQ_UNSPEC

[Patrick McHardy]

Pablo Neira Ayuso wrote:
> This patch fixes an inconsistency in nfnetlink_conntrack.h that
> I introduced myself. The problem is that CTA_NAT_SEQ_UNSPEC is
> missing from enum ctattr_natseq. This inconsistency may lead to
> problems in the message parsing in userspace (if the message
> contains the CTA_NAT_SEQ_* attributes, of course).
> 
> This patch breaks backward compatibility, however, the only known
> client of this code is libnetfilter_conntrack which indeed crashes
> because it assumes the existence of CTA_NAT_SEQ_UNSPEC to do
> the parsing.
> 
> The CTA_NAT_SEQ_* attributes were introduced in 2.6.25.

Applied, thanks.

Re: [PATCH] netfilter: ctnetlink: fix missing CTA_NAT_SEQ_UNSPEC

[Pablo Neira Ayuso]

Patrick McHardy wrote:
> Pablo Neira Ayuso wrote:
>> This patch fixes an inconsistency in nfnetlink_conntrack.h that
>> I introduced myself. The problem is that CTA_NAT_SEQ_UNSPEC is
>> missing from enum ctattr_natseq. This inconsistency may lead to
>> problems in the message parsing in userspace (if the message
>> contains the CTA_NAT_SEQ_* attributes, of course).
>>
>> This patch breaks backward compatibility, however, the only known
>> client of this code is libnetfilter_conntrack which indeed crashes
>> because it assumes the existence of CTA_NAT_SEQ_UNSPEC to do
>> the parsing.
>>
>> The CTA_NAT_SEQ_* attributes were introduced in 2.6.25.
> 
> Applied, thanks.

Thanks Patrick. This one should go to 2.6.28 as bugfix I think. Do you
plan to pass it to David?

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

Re: [PATCH] netfilter: ctnetlink: fix missing CTA_NAT_SEQ_UNSPEC

[Patrick McHardy]

Pablo Neira Ayuso wrote:
> Patrick McHardy wrote:
>> Pablo Neira Ayuso wrote:
>>> This patch fixes an inconsistency in nfnetlink_conntrack.h that
>>> I introduced myself. The problem is that CTA_NAT_SEQ_UNSPEC is
>>> missing from enum ctattr_natseq. This inconsistency may lead to
>>> problems in the message parsing in userspace (if the message
>>> contains the CTA_NAT_SEQ_* attributes, of course).
>>>
>>> This patch breaks backward compatibility, however, the only known
>>> client of this code is libnetfilter_conntrack which indeed crashes
>>> because it assumes the existence of CTA_NAT_SEQ_UNSPEC to do
>>> the parsing.
>>>
>>> The CTA_NAT_SEQ_* attributes were introduced in 2.6.25.
>> Applied, thanks.
> 
> Thanks Patrick. This one should go to 2.6.28 as bugfix I think. Do you
> plan to pass it to David?

Yes, I'll send it to Dave tonight.