From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] net: Remove a noisy printk Date: Mon, 15 Dec 2008 14:32:46 +0100 Message-ID: <49465C7E.8050103@trash.net> References: <1229033625-30825-1-git-send-email-ajax@redhat.com> <20081211.203243.124017657.davem@davemloft.net> <49464C2C.6030009@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Engelhardt , David Miller , ajax@redhat.com, linux-kernel@vger.kernel.org, davej@redhat.com, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org To: Jozsef Kadlecsik Return-path: Received: from stinky.trash.net ([213.144.137.162]:56704 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971AbYLONcz (ORCPT ); Mon, 15 Dec 2008 08:32:55 -0500 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jozsef Kadlecsik wrote: > On Mon, 15 Dec 2008, Patrick McHardy wrote: > >> I agree that it doesn't belong to the generic networking code. >> But the way its handled in netfilter is far from perfect as well. >> Currently multiple modules will spam the ringbuffer repeatedly, >> but offer no possibility to change anything in the behaviour of >> how these packets are treated. Unfortunately we can't handle this >> in the ruleset (which is exactly the reason why we're spamming >> the ringbuffer), so how about we add a module option controlling >> how to treat those packets and remove the printk? > > How about this: let the printk be removed from conntrack and the mangle > table but put (back) into the filter table with a module option, which > controls the behaviour (drop/accept & log/nolog)? Sounds fine to me. We can't log it in the usual way though (ipt_LOG/nfnetlink_log) and spamming the ringbuffer should really be a last resort, so I'd prefer to limit it to print the message exactly once.