From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Leblond <eric@inl.fr>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnetfilter_queue 0/4] misc code cleaning and documentation
Date: Mon, 22 Dec 2008 11:48:06 +0100 [thread overview]
Message-ID: <494F7066.8050401@netfilter.org> (raw)
In-Reply-To: <1229722591-7836-1-git-send-email-eric@inl.fr>
Eric Leblond wrote:
> Hi,
>
> This small patchset fixes two inconsistencies:
> * Change variable name to have an homogeneous naming
> * Use nfq_fd function instead of call to nfnetlink function.
> It also fixes a potential problem in nfq_close() where a ressource was freed twice:
> * Suppress double call of nfnl_subsys_close()
> Last patch is a documentation update:
> * Switch documentation style to doxygen.
> I've switched the documentation style to doxygen format. It is standard, easy
> to use and very powerful. An html output example is available here:
> http://www.nufw.org/doc/libnetfilter_queue/
>
> Patchset statistics:
> src/libnetfilter_queue.c | 437 ++++++++++++++++++++++++++++++++--------------
> utils/nfqnl_test.c | 3 +-
> 2 files changed, 310 insertions(+), 130 deletions(-)
They all look fine, please feel free to push them yourself to
netfilter's git.
--
"Los honestos son inadaptados sociales" -- Les Luthiers
prev parent reply other threads:[~2008-12-22 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 21:36 [libnetfilter_queue 0/4] misc code cleaning and documentation Eric Leblond
2008-12-19 21:36 ` [libnetfilter_queue 1/4] Change variable name to have an homogeneous naming Eric Leblond
2008-12-19 21:36 ` [libnetfilter_queue 2/4] Use nfq_fd function instead of call to nfnetlink function Eric Leblond
2008-12-19 21:36 ` [libnetfilter_queue 3/4] Suppress double call of nfnl_subsys_close() Eric Leblond
2008-12-19 21:36 ` [libnetfilter_queue 4/4] Switch documentation style to doxygen Eric Leblond
2008-12-22 10:45 ` Pablo Neira Ayuso
2008-12-22 10:55 ` Eric Leblond
2008-12-22 10:59 ` [libnetfilter_queue] Add doxygen config file Eric Leblond
2008-12-22 11:41 ` Pablo Neira Ayuso
2008-12-22 12:56 ` Eric Leblond
2008-12-22 12:32 ` [libnetfilter_queue 4/4] Switch documentation style to doxygen Pablo Neira Ayuso
2008-12-22 13:50 ` Jan Engelhardt
2008-12-22 22:02 ` Pablo Neira Ayuso
2008-12-22 22:08 ` Jan Engelhardt
2008-12-22 10:48 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494F7066.8050401@netfilter.org \
--to=pablo@netfilter.org \
--cc=eric@inl.fr \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).