iptables -git automake warnings

iptables -git automake warnings

[Patrick McHardy]

I get this with the current iptables -git version:

Makefile.am:7: `:='-style assignments are not portable
Makefile.am:71: `:='-style assignments are not portable
Makefile.am:72: `:='-style assignments are not portable
Makefile.am:73: `:='-style assignments are not portable
Makefile.am:74: `:='-style assignments are not portable
Makefile.am:75: `:='-style assignments are not portable
Makefile.am:78: `:='-style assignments are not portable
Makefile.am:80: `:='-style assignments are not portable
Makefile.am:97: `%'-style pattern rules are a GNU make extension

Re: iptables -git automake warnings

[Patrick McHardy]

Patrick McHardy wrote:
> I get this with the current iptables -git version:
> 
> Makefile.am:7: `:='-style assignments are not portable
> Makefile.am:71: `:='-style assignments are not portable
> Makefile.am:72: `:='-style assignments are not portable
> Makefile.am:73: `:='-style assignments are not portable
> Makefile.am:74: `:='-style assignments are not portable
> Makefile.am:75: `:='-style assignments are not portable
> Makefile.am:78: `:='-style assignments are not portable
> Makefile.am:80: `:='-style assignments are not portable
> Makefile.am:97: `%'-style pattern rules are a GNU make extension

Additionally compilation aborts with:

make[2]: *** No rule to make target 
`../include/linux/netfilter_ipv4/ipt_DSCP.h', needed by `libipt_ECN.oo'. 
  Stop.

Re: iptables -git automake warnings

[Jan Engelhardt]

On Monday 2009-01-12 06:46, Patrick McHardy wrote:
>

parent de2a83cb5022c429ccf1b852688481a0d8ad95e5 (v1.4.3-rc1-17-gde2a83c)
commit f38ae2530b523f2b293e19021fab8ddae9f8435b
Author: Jan Engelhardt <jengelh@medozas.de>
Date:   Mon Jan 12 07:09:53 2009 +0100

build: use regular = assignments in Makefile

Resolves warnings:
Makefile.am:7: `:='-style assignments are not portable
Makefile.am:71: `:='-style assignments are not portable
etc.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
 Makefile.am |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index fd4d93f..d5f8875 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -4,7 +4,7 @@ ACLOCAL_AMFLAGS  = -I m4
 AUTOMAKE_OPTIONS = foreign subdir-objects
 
 AM_CFLAGS        = ${regular_CFLAGS} -I${top_builddir}/include -I${top_srcdir}/include ${kinclude_CFLAGS}
-SUBDIRS         := extensions
+SUBDIRS          = extensions
 if ENABLE_LIBIPQ
 SUBDIRS         += libipq
 endif
@@ -68,16 +68,16 @@ ip6tables_static_SOURCES    = ${ip6tables_multi_SOURCES} xtables.c
 ip6tables_static_CFLAGS     = ${ip6tables_multi_CFLAGS} -DNO_SHARED_LIBS=1
 ip6tables_static_LDADD      = -lm libiptc/libiptc.a extensions/libext6.a
 
-noinst_LIBRARIES := libiptc/libiptc.a
-bin_PROGRAMS     := iptables-xml
-sbin_PROGRAMS    :=
-noinst_PROGRAMS  :=
-man_MANS         := iptables.8 iptables-restore.8 iptables-save.8 \
-                    iptables-xml.8 ip6tables.8 ip6tables-restore.8 \
-                    ip6tables-save.8
-CLEANFILES       := iptables.8 ip6tables.8
+noinst_LIBRARIES = libiptc/libiptc.a
+bin_PROGRAMS     = iptables-xml
+sbin_PROGRAMS    =
+noinst_PROGRAMS  =
+man_MANS         = iptables.8 iptables-restore.8 iptables-save.8 \
+                   iptables-xml.8 ip6tables.8 ip6tables-restore.8 \
+                   ip6tables-save.8
+CLEANFILES       = iptables.8 ip6tables.8
 if ENABLE_DEVEL
-include_HEADERS  := include/xtables.h
+include_HEADERS  = include/xtables.h
 endif
 
 if ENABLE_STATIC
-- 
# Created with git-export-patch

Re: iptables -git automake warnings

[Patrick McHardy]

Jan Engelhardt wrote:
> build: use regular = assignments in Makefile
> 
> Resolves warnings:
> Makefile.am:7: `:='-style assignments are not portable
> Makefile.am:71: `:='-style assignments are not portable
> etc.
> 
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>

Applies, thanks Jan.

Re: iptables -git automake warnings

[Patrick McHardy]

Patrick McHardy wrote:
> Patrick McHardy wrote:
>> I get this with the current iptables -git version:
>>
>> Makefile.am:7: `:='-style assignments are not portable
>> Makefile.am:71: `:='-style assignments are not portable
>> Makefile.am:72: `:='-style assignments are not portable
>> Makefile.am:73: `:='-style assignments are not portable
>> Makefile.am:74: `:='-style assignments are not portable
>> Makefile.am:75: `:='-style assignments are not portable
>> Makefile.am:78: `:='-style assignments are not portable
>> Makefile.am:80: `:='-style assignments are not portable
>> Makefile.am:97: `%'-style pattern rules are a GNU make extension
> 
> Additionally compilation aborts with:
> 
> make[2]: *** No rule to make target 
> `../include/linux/netfilter_ipv4/ipt_DSCP.h', needed by `libipt_ECN.oo'. 
>  Stop.

This is resolved by using a fresh clone.

Re: iptables -git automake warnings

[Jan Engelhardt]

On Monday 2009-01-12 07:10, Patrick McHardy wrote:

> Patrick McHardy wrote:
>> Patrick McHardy wrote:
>>> I get this with the current iptables -git version:
>>>
>>> Makefile.am:7: `:='-style assignments are not portable
>>> Makefile.am:71: `:='-style assignments are not portable
>>> Makefile.am:72: `:='-style assignments are not portable
>>> Makefile.am:73: `:='-style assignments are not portable
>>> Makefile.am:74: `:='-style assignments are not portable
>>> Makefile.am:75: `:='-style assignments are not portable
>>> Makefile.am:78: `:='-style assignments are not portable
>>> Makefile.am:80: `:='-style assignments are not portable
>>> Makefile.am:97: `%'-style pattern rules are a GNU make extension
>>
>> Additionally compilation aborts with:
>>
>> make[2]: *** No rule to make target
>> `../include/linux/netfilter_ipv4/ipt_DSCP.h', needed by `libipt_ECN.oo'.
>> Stop.
>
> This is resolved by using a fresh clone.

Must have been a really old tree, since no .c file besides
libipt_DSCP.c (long renamed libxt_DSCP.c) ever used ipt_DSCP.h.

Re: iptables -git automake warnings

[Patrick McHardy]

Jan Engelhardt wrote:
> On Monday 2009-01-12 07:10, Patrick McHardy wrote:
> 
>> Patrick McHardy wrote:
>>> Patrick McHardy wrote:
>>>> I get this with the current iptables -git version:
>>>>
>>>> Makefile.am:7: `:='-style assignments are not portable
>>>> Makefile.am:71: `:='-style assignments are not portable
>>>> Makefile.am:72: `:='-style assignments are not portable
>>>> Makefile.am:73: `:='-style assignments are not portable
>>>> Makefile.am:74: `:='-style assignments are not portable
>>>> Makefile.am:75: `:='-style assignments are not portable
>>>> Makefile.am:78: `:='-style assignments are not portable
>>>> Makefile.am:80: `:='-style assignments are not portable
>>>> Makefile.am:97: `%'-style pattern rules are a GNU make extension
>>> Additionally compilation aborts with:
>>>
>>> make[2]: *** No rule to make target
>>> `../include/linux/netfilter_ipv4/ipt_DSCP.h', needed by `libipt_ECN.oo'.
>>> Stop.
>> This is resolved by using a fresh clone.
> 
> Must have been a really old tree, since no .c file besides
> libipt_DSCP.c (long renamed libxt_DSCP.c) ever used ipt_DSCP.h.

Possibly, I usually don't delete the tree. The error didn't happen
previously for some reason.

Re: iptables -git automake warnings

[Jan Engelhardt]

On Monday 2009-01-12 06:44, Patrick McHardy wrote:
> Makefile.am:97: `%'-style pattern rules are a GNU make extension

parent f38ae2530b523f2b293e19021fab8ddae9f8435b (v1.4.3-rc1-18-gf38ae25)
commit 3e95daeb83446a61afa86914c9f1a03fa257537d
Author: Jan Engelhardt <jengelh@medozas.de>
Date:   Mon Jan 12 07:10:51 2009 +0100

build: remove non-portable rule

>Makefile.am:97: `%'-style pattern rules are a GNU make extension

(iptables still requires GNU make for extensions/, because it is
so much easier to write.)

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
 Makefile.am |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index d5f8875..4852d2a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -94,9 +94,6 @@ iptables.8: ${srcdir}/iptables.8.in extensions/matches4.man extensions/targets4.
 ip6tables.8: ${srcdir}/ip6tables.8.in extensions/matches6.man extensions/targets6.man
 	${AM_VERBOSE_GEN} sed -e 's/@PACKAGE_AND_VERSION@/${PACKAGE} ${PACKAGE_VERSION}/g' -e '/@MATCH@/ r extensions/matches6.man' -e '/@TARGET@/ r extensions/targets6.man' $< >$@;
 
-extensions/%:
-	${MAKE} ${AM_MAKEFLAGS} -C $(@D) $(@F)
-
 pkgconfig_DATA = xtables.pc
 
 .PHONY: tarball
-- 
# Created with git-export-patch

Re: iptables -git automake warnings

[Patrick McHardy]

Jan Engelhardt wrote:
> build: remove non-portable rule
> 
>> Makefile.am:97: `%'-style pattern rules are a GNU make extension
> 
> (iptables still requires GNU make for extensions/, because it is
> so much easier to write.)
> 

Also applied, thanks.