Re: [PATCH iptables] libxt_output: add more spaces to output

Re: [PATCH iptables] libxt_output: add more spaces to output

[Jan Engelhardt]

On Saturday 2009-01-17 14:14, Daniel Drake wrote:

>Commit bb9284d1 ("libxt_owner: add spaces to output") moved the printing
>of spaces away from the owner_mt_print() function family, but forgot to
>add spaces in all of the print_item() functions that are called.
>
>This is likely to be at least the partial cause of
>https://bugs.gentoo.org/show_bug.cgi?id=254435

Approves-of-this-patch: Jan Engelhardt <jengelh@medozas.de>

>Index: iptables-20090116/extensions/libxt_owner.c
>===================================================================
>--- iptables-20090116.orig/extensions/libxt_owner.c
>+++ iptables-20090116/extensions/libxt_owner.c
>@@ -324,7 +324,7 @@ owner_mt_print_item_v0(const struct ipt_
> 		return;
> 	if (info->invert & flag)
> 		printf("! ");
>-	printf(label);
>+	printf("%s ", label);
> 
> 	switch (info->match & flag) {
> 	case IPT_OWNER_UID:
>@@ -375,7 +375,7 @@ owner_mt6_print_item_v0(const struct ip6
> 		return;
> 	if (info->invert & flag)
> 		printf("! ");
>-	printf(label);
>+	printf("%s ", label);
> 
> 	switch (info->match & flag) {
> 	case IP6T_OWNER_UID:
>

Re: [PATCH iptables] libxt_output: add more spaces to output

[Patrick McHardy]

Jan Engelhardt wrote:
> On Saturday 2009-01-17 14:14, Daniel Drake wrote:
> 
>> Commit bb9284d1 ("libxt_owner: add spaces to output") moved the printing
>> of spaces away from the owner_mt_print() function family, but forgot to
>> add spaces in all of the print_item() functions that are called.
>>
>> This is likely to be at least the partial cause of
>> https://bugs.gentoo.org/show_bug.cgi?id=254435
> 
> Approves-of-this-patch: Jan Engelhardt <jengelh@medozas.de>

Applied, thanks.