netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Leblond <eric@inl.fr>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] netfilter: log invalid new icmpv6 packet with  nf_log_packet().
Date: Thu, 29 Jan 2009 21:57:21 +0100	[thread overview]
Message-ID: <49821831.6000609@inl.fr> (raw)
In-Reply-To: <20090129204754.GA22097@x200.localdomain>

Hi,

Alexey Dobriyan a écrit :
> On Thu, Jan 29, 2009 at 09:36:22PM +0100, Eric Leblond wrote:
>> --- a/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
>> +++ b/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
>> @@ -126,6 +126,10 @@ static bool icmpv6_new(struct nf_conn *ct, const struct sk_buff *skb,
>>  		pr_debug("icmpv6: can't create new conn with type %u\n",
>>  			 type + 128);
>>  		nf_ct_dump_tuple_ipv6(&ct->tuplehash[0].tuple);
>> +		if (LOG_INVALID(&init_net, IPPROTO_ICMPV6))
> 
> netns is nf_ct_net(ct) at this point, not &init_net.

Thanks a lot, updated patch to follow.

BR,
--
Eric Leblond <eric@inl.fr>

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-01-29 20:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-29 20:36 [PATCH 0/2] fix invalid packet logging for icmpv6 conntrack Eric Leblond
2009-01-29 20:36 ` [PATCH 1/2] netfilter: fix nf_log_packet message in " Eric Leblond
2009-02-09 17:15   ` Patrick McHardy
2009-01-29 20:36 ` [PATCH 2/2] netfilter: log invalid new icmpv6 packet with nf_log_packet() Eric Leblond
2009-01-29 20:47   ` Alexey Dobriyan
2009-01-29 20:57     ` Eric Leblond [this message]
2009-01-29 20:59       ` [PATCH] " Eric Leblond
2009-02-09 17:17         ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49821831.6000609@inl.fr \
    --to=eric@inl.fr \
    --cc=adobriyan@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).