netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: jamal <hadi@cyberus.ca>,
	kaber@trash.net,
	Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>
Subject: Re: libxtables: prefix names and order it #1
Date: Sun, 01 Feb 2009 22:17:59 +0100	[thread overview]
Message-ID: <49861187.3020708@netfilter.org> (raw)
In-Reply-To: <alpine.LSU.2.00.0901300550390.23947@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Tuesday 2009-01-27 15:29, jamal wrote:
>> On Tue, 2009-01-27 at 09:19 -0500, jamal wrote:
>>
>>> Ok, no problem - let me know when you are done.
>> BTW, it would be nice if you commit those patches to the git tree and i
>> pull them.
> 
> The proposed changes are at
> 
> 	git://dev.medozas.de/iptables master
> 
> 	92 files changed, 1063 insertions(+), 1135 deletions(-)
> 
> They are pretty broad, but repetitive.
> 
> There are a few functions left. Like exit_error, which still has ties
> to the origin program (iptables, ip6tables), to do option freeing for
> example. Have not yet thought of how to resolve that. Ideas welcome.

I think that you can move functions that are common to iptables and
ip6tables like exit_error(), merge_options(), ... and so on to
libxtables. I think that the purpose of this libxtables library should be:

1) To provide an API for jamal's tc ipt and your xtables-addon thing
(anyone willing to compile their .so files without recompiling iptables).
2) To factorize some code which is common to iptables and ip6tables.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

  parent reply	other threads:[~2009-02-01 21:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-27 14:01 libxtables: prefix names and order it #1 Jan Engelhardt
2009-01-27 14:11 ` libxtables: prefix names and order it #2 Jan Engelhardt
2009-01-27 14:23   ` libxtables: prefix names and order #3 Jan Engelhardt
2009-02-01 21:39     ` Pablo Neira Ayuso
2009-02-01 20:56   ` libxtables: prefix names and order it #2 Pablo Neira Ayuso
2009-02-01 21:38     ` Pablo Neira Ayuso
2009-01-27 14:19 ` libxtables: prefix names and order it #1 jamal
2009-01-27 14:29   ` jamal
2009-01-27 14:32     ` Jan Engelhardt
2009-01-27 14:36       ` Patrick McHardy
2009-01-30  4:52     ` Jan Engelhardt
2009-01-30 13:39       ` jamal
2009-02-01 21:17       ` Pablo Neira Ayuso [this message]
2009-02-01 20:52 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49861187.3020708@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=hadi@cyberus.ca \
    --cc=jengelh@medozas.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).