From: Nicolas Dichtel <nicolas.dichtel@dev.6wind.com>
To: netdev <netdev@vger.kernel.org>,
netfilter-devel <netfilter-devel@vger.kernel.org>,
Patrick McHardy <kaber@netfilter.org>
Subject: [PATCH] netfilter: sctp chunk mapping doesn't work
Date: Thu, 05 Feb 2009 10:26:58 +0100 [thread overview]
Message-ID: <498AB0E2.50507@dev.6wind.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
When user tries to map all chunks given in argument, kernel works on a copy of
the chunkmap, but at the end it doesn't check the copy, but the orginal one.
Signed-off-by: Qu Haoran <haoran.qu@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
[-- Attachment #2: x.diff --]
[-- Type: text/x-patch, Size: 457 bytes --]
--- linux-2.6.28.2/net/netfilter/xt_sctp.c 2009-01-24 19:42:07.000000000 -0500
+++ linux-2.6.28.2-new/net/netfilter/xt_sctp.c 2009-02-05 04:13:31.000000000 -0500
@@ -105,7 +105,7 @@ match_packet(const struct sk_buff *skb,
switch (chunk_match_type) {
case SCTP_CHUNK_MATCH_ALL:
- return SCTP_CHUNKMAP_IS_CLEAR(info->chunkmap);
+ return SCTP_CHUNKMAP_IS_CLEAR(chunkmapcopy);
case SCTP_CHUNK_MATCH_ANY:
return false;
case SCTP_CHUNK_MATCH_ONLY:
next reply other threads:[~2009-02-05 9:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 9:26 Nicolas Dichtel [this message]
2009-02-09 14:36 ` [PATCH] netfilter: sctp chunk mapping doesn't work Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498AB0E2.50507@dev.6wind.com \
--to=nicolas.dichtel@dev.6wind.com \
--cc=kaber@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).