From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] netfilter: unfold two critical loops in ip_packet_match() Date: Mon, 09 Feb 2009 14:41:56 +0100 Message-ID: <499032A4.9090301@trash.net> References: <497F4C2F.9000804@hp.com> <497F5BCD.9060807@hp.com> <497F5F86.9010101@hp.com> <498063E7.5030106@cosmosbay.com> <49808708.3050502@trash.net> <498090C1.5020400@cosmosbay.com> <49809716.3020204@cosmosbay.com> <4981CBE2.5020306@cosmosbay.com> <87ocxox0bu.fsf@basil.nowhere.org> <498330B2.4060004@cosmosbay.com> <20090130172705.GB18453@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Eric Dumazet , "David S. Miller" , Netfilter Developers , Linux Network Development list To: Andi Kleen Return-path: Received: from stinky.trash.net ([213.144.137.162]:55037 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756393AbZBINl6 (ORCPT ); Mon, 9 Feb 2009 08:41:58 -0500 In-Reply-To: <20090130172705.GB18453@one.firstfloor.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Andi Kleen wrote: > On Fri, Jan 30, 2009 at 05:54:10PM +0100, Eric Dumazet wrote: >> Andi Kleen a =E9crit : >>> Eric Dumazet writes: >>> >>>> While doing oprofile tests I noticed two loops are not properly un= rolled by gcc >>> That's because nobody passed -funroll-loops. Did you try that for >>> that file? Likely will need -O2 too >> I dont want to unroll all loops, only those two :) >=20 > gcc 4.4 will have a way to do that per function, but earlier > you would need to move it to a separate file and specify > the option only for that. >=20 > Doing so would be still a good idea compared to your > patch because the code will be cleaner and might > be more adaptable to future architectures > (such manual tunings tend to outdate) The interface name matching has shown up in profiles forever though and we've actually already tried to optimize it IIRC. Eric, I'm trying to keep all the *tables files synchronized, could you send me a patch updating the other ones as well please? -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html