* [PATCH] netfilter: sctp chunk mapping doesn't work
@ 2009-02-05 9:26 Nicolas Dichtel
2009-02-09 14:36 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Dichtel @ 2009-02-05 9:26 UTC (permalink / raw)
To: netdev, netfilter-devel, Patrick McHardy
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
When user tries to map all chunks given in argument, kernel works on a copy of
the chunkmap, but at the end it doesn't check the copy, but the orginal one.
Signed-off-by: Qu Haoran <haoran.qu@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
[-- Attachment #2: x.diff --]
[-- Type: text/x-patch, Size: 457 bytes --]
--- linux-2.6.28.2/net/netfilter/xt_sctp.c 2009-01-24 19:42:07.000000000 -0500
+++ linux-2.6.28.2-new/net/netfilter/xt_sctp.c 2009-02-05 04:13:31.000000000 -0500
@@ -105,7 +105,7 @@ match_packet(const struct sk_buff *skb,
switch (chunk_match_type) {
case SCTP_CHUNK_MATCH_ALL:
- return SCTP_CHUNKMAP_IS_CLEAR(info->chunkmap);
+ return SCTP_CHUNKMAP_IS_CLEAR(chunkmapcopy);
case SCTP_CHUNK_MATCH_ANY:
return false;
case SCTP_CHUNK_MATCH_ONLY:
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] netfilter: sctp chunk mapping doesn't work
2009-02-05 9:26 [PATCH] netfilter: sctp chunk mapping doesn't work Nicolas Dichtel
@ 2009-02-09 14:36 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2009-02-09 14:36 UTC (permalink / raw)
To: nicolas.dichtel; +Cc: netdev, netfilter-devel
Nicolas Dichtel wrote:
> When user tries to map all chunks given in argument, kernel works on a
> copy of the chunkmap, but at the end it doesn't check the copy, but the
> orginal one.
Applied, thanks Nicolas.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-09 14:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-05 9:26 [PATCH] netfilter: sctp chunk mapping doesn't work Nicolas Dichtel
2009-02-09 14:36 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).