* netfilter: src: remove unneeded goto
@ 2009-01-16 23:52 Jan Engelhardt
2009-02-09 16:04 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Jan Engelhardt @ 2009-01-16 23:52 UTC (permalink / raw)
To: kaber; +Cc: Netfilter Developer Mailing List
Still valid for 2.6.29-rc2.
---8<---
parent 8825f047f639abd185399969c8e3b863b6af0a28 (v2.6.28-rc2-661-g8825f04)
commit ccdb1cf1a4417b7282c6b49723eef3ffe8758130
Author: Jan Engelhardt <jengelh@medozas.de>
Date: Sun Nov 30 16:35:34 2008 +0100
netfilter: src: remove unneeded goto
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
net/netfilter/core.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/core.c b/net/netfilter/core.c
index a90ac83..5bb3473 100644
--- a/net/netfilter/core.c
+++ b/net/netfilter/core.c
@@ -174,7 +174,6 @@ next_hook:
outdev, &elem, okfn, hook_thresh);
if (verdict == NF_ACCEPT || verdict == NF_STOP) {
ret = 1;
- goto unlock;
} else if (verdict == NF_DROP) {
kfree_skb(skb);
ret = -EPERM;
@@ -183,7 +182,6 @@ next_hook:
verdict >> NF_VERDICT_BITS))
goto next_hook;
}
-unlock:
rcu_read_unlock();
return ret;
}
--
# Created with git-export-patch
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: netfilter: src: remove unneeded goto
2009-01-16 23:52 netfilter: src: remove unneeded goto Jan Engelhardt
@ 2009-02-09 16:04 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2009-02-09 16:04 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Netfilter Developer Mailing List
Jan Engelhardt wrote:
> netfilter: src: remove unneeded goto
>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-09 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-16 23:52 netfilter: src: remove unneeded goto Jan Engelhardt
2009-02-09 16:04 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).