From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: netfilter: half a patch for the pseudoregression
Date: Mon, 09 Feb 2009 17:20:44 +0100 [thread overview]
Message-ID: <499057DC.9000102@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.00.0901272322210.31372@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
>
> Here is the sample patch that fixes ip_tables_matches, but I still
> challenge the usefulness of /proc/net/ip_tables_* altogether.
> Those files should have been removed, or appropriately upgraded when
> revision support was introduced.
Thats not really the question right now since it exists and people
are using it. Feel free to start a discussion on removing it once
we've fixed the regression.
> netfilter: make proc/net/ip_tables_matches print names from foreign NFPROTO
>
> The ugliness this code adds could have been better spent at
> a full and much more helpful dump.
This might get easier by simply using the same mutex for all families.
Not sure if its worth it, in any case not for now.
The patch looks fine, please resubmit when you have fixed the second
half with proper changelog (stating that it fixes a regression and
the commit introducing it).
next prev parent reply other threads:[~2009-02-09 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 22:30 netfilter: half a patch for the pseudoregression Jan Engelhardt
2009-02-09 16:20 ` Patrick McHardy [this message]
2009-02-12 4:28 ` Jan Engelhardt
2009-02-17 18:53 ` Jan Engelhardt
2009-02-18 14:35 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499057DC.9000102@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).