From: Scott Feldman <scofeldm@cisco.com>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] Update jhash.h with the new version of Jenkins' hash
Date: Tue, 10 Feb 2009 13:19:55 -0800 [thread overview]
Message-ID: <4991EF7B.90004@cisco.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0902102026060.10299@blackhole.kfki.hu>
Jozsef Kadlecsik wrote:
> The patch replaces the lookup2() implementation of the 'jhash*'
> functions with that of lookup3().
Should the lookup3() be added to rather than replacing lookup2()? In
case some hardware vendor used the lookup2() version for weird things
like flow classification.
> /* The golden ration: an arbitrary value */
> -#define JHASH_GOLDEN_RATIO 0x9e3779b9
> +#define JHASH_GOLDEN_RATIO 0xdeadbeef
The #define seems mis-named now.
-scott
next prev parent reply other threads:[~2009-02-10 21:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 19:40 [PATCH] Update jhash.h with the new version of Jenkins' hash Jozsef Kadlecsik
2009-02-10 21:19 ` Scott Feldman [this message]
2009-02-10 22:03 ` Jozsef Kadlecsik
2009-02-11 1:17 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-02-11 10:19 Jozsef Kadlecsik
2009-02-11 20:19 ` Michał Mirosław
2009-02-11 22:50 ` Jozsef Kadlecsik
2009-02-11 23:23 ` Michał Mirosław
2009-02-12 0:12 ` wli
2009-02-12 0:29 ` David Miller
2009-02-12 0:41 ` Jan Engelhardt
2009-02-12 9:05 ` Jarek Poplawski
2009-02-12 9:55 ` Jarek Poplawski
2009-02-12 9:11 ` Jozsef Kadlecsik
2009-02-12 9:16 ` Patrick McHardy
2009-02-12 9:41 ` Jozsef Kadlecsik
2009-02-12 13:46 ` Kyle Moffett
2009-02-17 17:13 ` Jozsef Kadlecsik
2009-02-18 5:11 ` Rusty Russell
2009-02-18 11:50 ` Ilpo Järvinen
2009-02-12 19:58 ` Eric W. Biederman
2009-02-12 2:58 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4991EF7B.90004@cisco.com \
--to=scofeldm@cisco.com \
--cc=davem@davemloft.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).