netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: pull request
Date: Thu, 12 Feb 2009 06:46:28 +0100	[thread overview]
Message-ID: <4993B7B4.70901@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.00.0902120632140.32504@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Thursday 2009-02-12 06:29, Patrick McHardy wrote:
>> jengelh@medozas.de wrote:
>>> 13 files changed, 108 insertions(+), 182 deletions(-)
>> This diffstat I get looks quite different:
>>
>> 11 files changed, 73 insertions(+), 67 deletions(-)
>>
>> Any idea whats going on there?
>>
> 
> I used git diff --stat instead of whatever merge outputs.

That gives the same (different) output for me.

> $ git diff --stat nf/master..mdz/master
> [13 files, 108+, 182-]
> $ git rev-parse nf/master
> 8b7baebc93989106fd5d26b262d0ce191f8ef7c0
> $ git rev-parse mdz/master
> 47a6fd9ec9891a8040eb8fd6db3c5012c1056061

Well, it doesn't add up at all, even in those changelogs you posted
f.i. the xtables.c lines amount to something in the order of 30, not
over 100. The tree looks fine from a quick look, but I want to make
sure that what I'm pulling is indeed what you intended to send me.

I'll skip this pull, please send a new request (with or without Jamal's
patches, as you like) once you figured out where those differences are
coming from.

  reply	other threads:[~2009-02-12  5:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 15:03 pull request jengelh
2009-02-11 15:03 ` [PATCH 1/8] libxtables: recognize IP6TABLES_LIB_DIR old-style environment variable jengelh
2009-02-11 15:03 ` [PATCH 2/8] build: move -ldl to proper LDADD jengelh
2009-02-11 15:03 ` [PATCH 3/8] libxtables: remove unused XT_LIB_DIR macro jengelh
2009-02-11 15:03 ` [PATCH 4/8] libxtables: decouple non-xtables parts from header jengelh
2009-02-11 15:03 ` [PATCH 5/8] src: remove iptables_rule_match indirection macro jengelh
2009-02-11 15:03 ` [PATCH 6/8] src: remove unused ipt_tryload macro jengelh
2009-02-11 15:03 ` [PATCH 7/8] libxtables: move compat defines to xtables.c jengelh
2009-02-11 15:03 ` [PATCH 8/8] src: consolidate duplicate code in iptables/internal.h jengelh
2009-02-11 15:06 ` pull request Patrick McHardy
2009-02-11 15:45   ` Jan Engelhardt
2009-02-11 23:40     ` Jan Engelhardt
2009-02-12  5:11       ` Patrick McHardy
2009-02-12  5:40         ` Jan Engelhardt
2009-02-12  5:45           ` Patrick McHardy
2009-02-12  5:29 ` Patrick McHardy
2009-02-12  5:33   ` Jan Engelhardt
2009-02-12  5:46     ` Patrick McHardy [this message]
2009-02-12  6:05       ` Jan Engelhardt
2009-02-12  6:10         ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4993B7B4.70901@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).