netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philip Craig <philipc@snapgear.com>
To: Thomas Jarosch <thomas.jarosch@intra2net.com>
Cc: Jan Engelhardt <jengelh@medozas.de>,
	hadi@cyberus.ca, Patrick McHardy <kaber@trash.net>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] libxtables: Dont initialize global xt_params
Date: Mon, 16 Feb 2009 14:51:58 +1000	[thread overview]
Message-ID: <4998F0EE.3020404@snapgear.com> (raw)
In-Reply-To: <200902121641.54430.thomas.jarosch@intra2net.com>

Thomas Jarosch wrote:
> Well, I guess that's a job for the compiler/optimizer. I did a quick test by 
> writing two versions of a small program initializing a static variable with 
> zero and one version that doesn't (=zeroed in .bss). Guess what,
> the size of the resulting executable stays the same.
> 
> When I initialize the variable with a non-zero value, then the program size 
> increases. I tested "-O2", "-O0" and "-Os" and the results where the same.
> Feel free to look at the assembler output, though I guess this optimization
> is not measurable and makes the code harder to read :o)

For gcc, this depends on the -fno-zero-initialized-in-bss option.
Recommendations to avoid zero initialization generally come from
a time when gcc didn't do this by default.  Now it is more just
personal preference.


  parent reply	other threads:[~2009-02-16  4:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 14:16 [PATCH] libxtables: Dont initialize global xt_params jamal
2009-02-12 15:09 ` Thomas Jarosch
2009-02-12 15:14   ` Jan Engelhardt
2009-02-12 15:41     ` Thomas Jarosch
2009-02-13 13:49       ` jamal
2009-02-13 18:11         ` Thomas Jarosch
2009-02-16  4:51       ` Philip Craig [this message]
2009-02-16 10:38         ` Patrick McHardy
2009-02-17 14:46           ` Thomas Jarosch
2009-02-17 14:54             ` Patrick McHardy
2009-02-12 16:39 ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4998F0EE.3020404@snapgear.com \
    --to=philipc@snapgear.com \
    --cc=hadi@cyberus.ca \
    --cc=jengelh@medozas.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=thomas.jarosch@intra2net.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).