netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Adam Nielsen <a.nielsen@shikadi.net>
Cc: Richard Purdie <rpurdie@linux.intel.com>,
	Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 2/2 v5] New netfilter target to trigger LED devices
Date: Thu, 19 Feb 2009 11:14:55 +0100	[thread overview]
Message-ID: <499D311F.7050304@trash.net> (raw)
In-Reply-To: <499C899F.5010002@shikadi.net>

Adam Nielsen wrote:
>> Adam, I wanted to apply this, but I get rejects for every single
>> existing file. There appears to be some whitespace damage, please
>> resend as attachment.
> 
> Hmm, that's odd - Thunderbird must not like sending tabs - sorry
> about that!
> 
> I hope the attached files work better.

It applies with some minor manual fixups (please diff against the
nf-next tree at git.kernel.org). It doesn't compile though:

   CC [M]  net/netfilter/xt_LED.o
net/netfilter/xt_LED.c:40: error: field 'netfilter_led_trigger' has 
incomplete type
net/netfilter/xt_LED.c: In function 'led_timeout_callback':
net/netfilter/xt_LED.c:77: warning: unused variable 'ledinternal'
net/netfilter/xt_LED.c: In function 'led_tg_check':
net/netfilter/xt_LED.c:101: error: implicit declaration of function 
'led_trigger_register'
net/netfilter/xt_LED.c: In function 'led_tg_destroy':
net/netfilter/xt_LED.c:134: error: implicit declaration of function 
'led_trigger_unregister'

  reply	other threads:[~2009-02-19 10:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 21:45 [PATCH 2/2 v4] New netfilter target to trigger LED devices Adam Nielsen
2009-02-12  5:27 ` Patrick McHardy
2009-02-12 11:51   ` [PATCH 2/2 v5] " Adam Nielsen
2009-02-16 16:03     ` Patrick McHardy
2009-02-17 13:50       ` Richard Purdie
2009-02-18 14:14         ` Patrick McHardy
2009-02-18 22:20           ` Adam Nielsen
2009-02-19 10:14             ` Patrick McHardy [this message]
2009-02-20  9:57             ` Patrick McHardy
2009-02-22 14:16               ` Adam Nielsen
2009-02-24 13:51                 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499D311F.7050304@trash.net \
    --to=kaber@trash.net \
    --cc=a.nielsen@shikadi.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=rpurdie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).