netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org, hadi@cyberus.ca
Subject: Re: [PATCH 3/6] libxtables: prefix exit_error to xtables_error
Date: Mon, 23 Feb 2009 17:56:18 +0100	[thread overview]
Message-ID: <49A2D532.2050506@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.00.0902231751550.12150@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Monday 2009-02-23 17:46, Patrick McHardy wrote:
>> Jan Engelhardt wrote:
>>> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
>>> diff --git a/extensions/expr b/extensions/expr
>>> new file mode 100644
>>> index 0000000..f00b70d
>>> --- /dev/null
>>> +++ b/extensions/expr
>>> @@ -0,0 +1,179 @@
>>> +#include <stdio.h>
>>> +#include <stdint.h>
>>> +#include <libHX/option.h>
>>> +
>>> +enum ttl_rel {
>>> +	REL_EQ,
>>> +	REL_LT,
>>> +	REL_GT,
>>> +}
>> What is this file? I see no mentioning in the (non-existant) changelog.
>>
> Accidentally git-added code. It is removed in the latest tree's form.
> There should not need to be any detailed changelog entry - it
> really is just the prefixing that is needed for a good library
> that was done.
> 

This look a lot better:

  94 files changed, 778 insertions(+), 788 deletions(-)

:)

Pulled and pushed out again, thanks. Now lets slow things down until
the next release please.

  reply	other threads:[~2009-02-23 16:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-21  3:17 [pull] request for 20090220 Jan Engelhardt
2009-02-21  3:17 ` [PATCH 1/6] doc: resynchronize manpage with in-code help Jan Engelhardt
2009-02-21  3:18 ` [PATCH 2/6] libxtables: inline and remove unused OPTION_OFFSET macro Jan Engelhardt
2009-02-21  3:18 ` [PATCH 3/6] libxtables: prefix exit_error to xtables_error Jan Engelhardt
2009-02-21  7:37   ` Jesper Dangaard Brouer
2009-02-21 14:46     ` Jan Engelhardt
2009-02-23 16:46   ` Patrick McHardy
2009-02-23 16:53     ` Jan Engelhardt
2009-02-23 16:56       ` Patrick McHardy [this message]
2009-02-23 17:28         ` Jan Engelhardt
2009-02-27 19:16           ` Jan Engelhardt
2009-02-21  3:18 ` [PATCH 4/6] extensions: remove unwanted/add needed includes for IPv6 exts Jan Engelhardt
2009-02-21  3:18 ` [PATCH 5/6] extensions: remove unwanted/add needed includes for IPv4 exts Jan Engelhardt
2009-02-21  3:18 ` [PATCH 6/6] libxt_policy: use bounded strtoui Jan Engelhardt
2009-02-21 12:54 ` [pull] request for 20090220 jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A2D532.2050506@trash.net \
    --to=kaber@trash.net \
    --cc=hadi@cyberus.ca \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).