From: John Haxby <john.haxby@oracle.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: pud <pud@subnet666.de>,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: libxt_string: fix undefined behavior/incorrect patlen calculation
Date: Mon, 02 Mar 2009 09:16:00 +0000 [thread overview]
Message-ID: <49ABA3D0.1060906@oracle.com> (raw)
In-Reply-To: <alpine.LSU.2.00.0903020324590.10419@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Sunday 2009-03-01 23:37, pud wrote:
>
>> (sorry, msg-id lost)
>>
>>
>>> commit 19b0cd770d1e042c85bf0b278261a61d4cea8193
>>> Author: Jan Engelhardt <jeng...@medozas.de>
>>> Date: Thu Feb 12 01:18:35 2009 +0100
>>>
>> ...
>>
>>> - stringinfo->patlen=strlen((char *)&stringinfo->pattern);
>>> + stringinfo->patlen = strnlen((char *)&stringinfo->pattern,
>>> + sizeof(stringinfo->patlen));
>>>
>> sorry, this doesn't work here, did you mean
>> sizeof(stringinfo->pattern)?
>>
>
> What do you mean "doesnot work"?
>
It looks very weird to me as well. I may well be confused, but
stringinfo->patlen = strnlen((char *)&stringinfo->pattern,
sizeof(stringinfo->patlen))
looks like something roughly equivalent to this:
char pattern[256];
int patlen;
patlen = strlen(pattern, 4);
The "4" is sizeof(int) rather than the size of "pattern"
jch
next prev parent reply other threads:[~2009-03-02 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-01 22:37 libxt_string: fix undefined behavior/incorrect patlen calculation pud
2009-03-02 2:25 ` Jan Engelhardt
2009-03-02 9:16 ` John Haxby [this message]
2009-03-02 10:48 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2009-02-12 0:21 Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ABA3D0.1060906@oracle.com \
--to=john.haxby@oracle.com \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pud@subnet666.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).