Linux Netfilter development
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: netfilter: xtables: avoid pointer to self
Date: Mon, 16 Mar 2009 15:36:06 +0100	[thread overview]
Message-ID: <49BE63D6.1090306@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.00.0903031806350.8887@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> (There is a 2nd patch as reply, could you please fold that.)
> 
> ---8<---
> netfilter: xtables: avoid pointer to self
> 
> Commit 784544739a25c30637397ace5489eeb6e15d7d49 (netfilter: iptables: 
> lock free counters) broke a number of modules whose rule data referenced 
> itself. A reallocation would not reestablish the correct references, so 
> it is best to use a separate struct that does not fall under RCU.

Applied, including the second patch. Thanks.


      parent reply	other threads:[~2009-03-16 14:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03 17:09 netfilter: xtables: avoid pointer to self Jan Engelhardt
2009-03-03 17:09 ` netfilter: xtables: avoid pointer to self (2) Jan Engelhardt
2009-03-16 14:36 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49BE63D6.1090306@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox