From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: (pull) pending patches
Date: Mon, 16 Mar 2009 18:13:37 +0100 [thread overview]
Message-ID: <49BE88C1.6000004@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.00.0903161809270.17820@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Monday 2009-03-16 18:03, Patrick McHardy wrote:
>
>> Jan Engelhardt wrote:
>>> On Monday 2009-03-16 17:44, Patrick McHardy wrote:
>>>
>>>>> All NAT modules -- libipt_DNAT, SNAT, MASQUERADE, NETMAP, REDIRECT --
>>>>> use struct nf_nat_multi_range, which is also only in nf_nat.h.
>>>> Indeed, that one should be exported. But in order to that is should
>>>> be moved to include/linux/netfilter instead of using include/net
>>>> includes in userspace.
>>>>
>>> I agree. If however it does not make it into 2.6.29 I would suggest
>>> going with the proposed iptables tree with a manually-copied
>>> nf_nat.h, though.
>> Fair enough. Which branch do you want me to pull?
>>
> master, please.
The diffstat looks massively different again. Careful comparision
shows it actually *is* what you asked to pull, but please include
a proper diffstat in the future so I don't have to do this every
time I pull.
Anyways, pulled and pushed out again, thanks.
prev parent reply other threads:[~2009-03-16 17:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 20:44 (pull) pending patches Jan Engelhardt
2009-03-16 8:38 ` Pablo Neira Ayuso
2009-03-16 10:54 ` Jan Engelhardt
2009-03-16 13:39 ` Patrick McHardy
2009-03-16 13:41 ` Jan Engelhardt
2009-03-16 13:42 ` Patrick McHardy
2009-03-16 16:42 ` Jan Engelhardt
2009-03-16 16:44 ` Patrick McHardy
2009-03-16 16:49 ` Jan Engelhardt
2009-03-16 17:03 ` Patrick McHardy
2009-03-16 17:09 ` Jan Engelhardt
2009-03-16 17:13 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BE88C1.6000004@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox