Linux Netfilter development
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Soren Hansen <soren@ubuntu.com>, netfilter-devel@vger.kernel.org
Subject: Re: Automatically load modules in iptables-save
Date: Fri, 20 Mar 2009 19:42:04 +0100	[thread overview]
Message-ID: <49C3E37C.50107@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.00.0903191701060.14674@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> Here is a reworked version that also adds the missing IPv6
> and manpage bits, pullable from the usual place at
> 
>  git://dev.medozas.de/iptables master
> 
> ---8<---
> iptables-save: module loading corrections
> 
> 1. Ignore the absence of /proc/net/ip_tables_names, which happens
> when x_tables.ko is not loaded. This is equivalent to having
> x_tables.ko, but no tabe modules, loaded. As such, success should
> be returned.
> 
> 2. Load table when explicitly requested by the -t option. Users might
> expect "*foo" etc. to be output when `iptables-save -t foo` is
> executed. So do autoload x_tables.ko and the table in this case.
> 
> *. Do this for both iptables-save and ip6tables-save, and adjust
> the manpages for the new -M (modprobe program location) option that
> is introduced.
> 
> Based upon a patch by Soren Hansen.

Looks good, thanks Jan. Pulled and pushed out.

  parent reply	other threads:[~2009-03-20 18:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-16 17:10 Automatically load modules in iptables-save Soren Hansen
2009-03-19 12:55 ` Soren Hansen
2009-03-19 13:05   ` Patrick McHardy
2009-03-19 13:50     ` Soren Hansen
2009-03-19 13:55       ` Jan Engelhardt
2009-03-19 13:58         ` Patrick McHardy
2009-03-19 14:29         ` Soren Hansen
2009-03-19 14:31           ` Jan Engelhardt
2009-03-19 15:43             ` Soren Hansen
2009-03-19 16:02               ` Jan Engelhardt
2009-03-19 17:00                 ` Soren Hansen
2009-03-20 18:42                 ` Patrick McHardy [this message]
2009-03-19 16:43               ` Soren Hansen
  -- strict thread matches above, loose matches on Subject: below --
2009-03-16 11:42 Soren Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C3E37C.50107@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=soren@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox