Re: [PATCH] [PATCH] dynamic calculation of event message size for ctnetlink

[Patrick McHardy <kaber@trash.net>]

Holger Eitzenberger wrote:
> On Wed, Mar 18, 2009 at 05:41:43AM +0100, Patrick McHardy wrote:
> 
>>> This calculation results in no message trim if most of those attributes
>>> are present. However, assuming the worst case (no counters, no helper,
>>> no mark, no master tuple, etc.), netlink_trim() may be called. My patch
>>> calculates the exact size, so there's no trimming for any case.
>> The numbers imply that its still a net win. But its a valid point, if
>> the common case will still result in reallocations, it might make sense
>> to include the space for a few of those members optionally to make
>> sure we don't cross the 50% waste threshold.
> 
> That's a good point.
> 
> For reference these are the attributes of TCP conntrack event, I have
> marked the optional NLAs.  I don't know what the ratio is in bytes
> though.

Thanks Holger. I'm going to apply your patches since they're already
an improvement, we can do further refinement on top.