From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 4/5] conntrack: ecache: move event cache to conntrack extension infrastructure Date: Fri, 27 Mar 2009 12:41:59 +0100 Message-ID: <49CCBB87.2080404@trash.net> References: <20090327093822.8259.50902.stgit@Decadence> <20090327094009.8259.64117.stgit@Decadence> <49CCA1DA.7060902@trash.net> <49CCBA7C.2090609@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Pablo Neira Ayuso Return-path: Received: from stinky.trash.net ([213.144.137.162]:59085 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbZC0LmJ (ORCPT ); Fri, 27 Mar 2009 07:42:09 -0400 In-Reply-To: <49CCBA7C.2090609@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Pablo Neira Ayuso wrote: > Patrick McHardy wrote: >> Generally, I'd say a better approach is to get rid of the notifier >> chain (unnecessary overhead for the single user we have), replace it >> by a function pointer for event delivery and use that as an indication >> that events should be tracked. > > I have a fuzzy morning. I get the idea of replacing the notifier chain > by a function pointer but I don't get the idea of the indication. Something like: if (nf_ct_deliver_events == NULL) don't cache events, try to avoid any other event-related overhead with nf_ct_deliver_events being the function pointer. Similar to the sysctl, that allows to enable/disable hopefully most of the event stuff at runtime.