From: Randy Dunlap <randy.dunlap@oracle.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
davem@davemloft.net, sfr@canb.auug.org.au,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, kaber@trash.net,
netfilter-devel@vger.kernel.org
Subject: Re: linux-next: Tree for March 27 (netfilter build error)
Date: Sat, 28 Mar 2009 21:26:42 -0700 [thread overview]
Message-ID: <49CEF882.5000005@oracle.com> (raw)
In-Reply-To: <20090328102852.GA7697@localhost>
Cyrill Gorcunov wrote:
> [David Miller - Fri, Mar 27, 2009 at 04:01:07PM -0700]
> | From: Randy Dunlap <randy.dunlap@oracle.com>
> | Date: Fri, 27 Mar 2009 09:48:40 -0700
> |
> | > Stephen Rothwell wrote:
> | > > Hi all,
> | > >
> | > > Changes since 20090326:
> | >
> | >
> | > with CONFIG_IPV6=n:
> | >
> | > ERROR: "__ipv6_addr_type" [net/netfilter/xt_cluster.ko] undefined!
> | >
> | > config attached.
> |
> | Patrick and netfilter folks, please have a look, thanks!
> |
>
> Pablo, seems like something as inlined below is
> missed? (except I doubt about CONFIG_IPV6_MODULE
> here)
>
> Cyrill
works_for_me. Thanks.
but missing S-O-B.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> net/netfilter/xt_cluster.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux-2.6.git/net/netfilter/xt_cluster.c
> ===================================================================
> --- linux-2.6.git.orig/net/netfilter/xt_cluster.c
> +++ linux-2.6.git/net/netfilter/xt_cluster.c
> @@ -67,8 +67,10 @@ xt_cluster_is_multicast_addr(const struc
> is_multicast = ipv4_is_multicast(ip_hdr(skb)->daddr);
> break;
> case NFPROTO_IPV6:
> +#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
> is_multicast = ipv6_addr_type(&ipv6_hdr(skb)->daddr) &
> IPV6_ADDR_MULTICAST;
> +#endif
> break;
> default:
> WARN_ON(1);
--
~Randy
next prev parent reply other threads:[~2009-03-29 4:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090327231924.4e4168c5.sfr@canb.auug.org.au>
[not found] ` <49CD0368.2010805@oracle.com>
2009-03-27 23:01 ` linux-next: Tree for March 27 (netfilter build error) David Miller
2009-03-28 10:28 ` Cyrill Gorcunov
2009-03-29 4:26 ` Randy Dunlap [this message]
2009-03-29 6:47 ` Cyrill Gorcunov
2009-03-29 6:47 ` David Miller
2009-03-29 11:48 ` Harald Welte
2009-03-29 11:59 ` Pablo Neira Ayuso
2009-03-29 12:27 ` Cyrill Gorcunov
2009-03-29 20:46 ` David Miller
2009-03-30 12:00 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CEF882.5000005@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=davem@davemloft.net \
--cc=gorcunov@gmail.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).