From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: panic on rmmod of nf_conntrack_irc
Date: Tue, 14 Apr 2009 14:16:37 +0200 [thread overview]
Message-ID: <49E47EA5.3060706@trash.net> (raw)
In-Reply-To: <49E47C2D.1050508@cosmosbay.com>
Eric Dumazet wrote:
> Patrick McHardy a écrit :
>> Mariusz Kozlowski wrote:
>>> netfilter: nf_conntrack: use SLAB_DESTROY_BY_RCU and get rid of
>>> call_rcu()
>> Thanks for the report. Does this patch fix it?
>>
>
> Hi Patrick, sorry for the delay, I was in holidays.
No problem, me too :)
> I should have used different fields names (from "next", "first", ...) to catch this
> kind of errors at compile time :(
>
> Something like :
Thanks Eric. I guess at this point it doesn't really matter anymore
for the upstream kernel, but I'll apply your patch after getting
confirmation from Mariusz to make sure that people maintaining
external patches will notice the change (and won't send me broken
patches :)).
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-04-14 12:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090410191736.21efab8c@mako-desktop>
2009-04-14 11:32 ` panic on rmmod of nf_conntrack_irc Patrick McHardy
2009-04-14 12:06 ` Eric Dumazet
2009-04-14 12:16 ` Patrick McHardy [this message]
2009-04-14 19:19 ` Mariusz Kozlowski
2009-04-14 20:06 ` Mariusz Kozlowski
2009-04-14 20:14 ` Eric Dumazet
2009-04-14 20:39 ` Mariusz Kozlowski
2009-04-14 20:46 ` Eric Leblond
2009-04-14 21:07 ` [PATCH] netfilter: nf_log fix Eric Dumazet
2009-04-15 10:20 ` Patrick McHardy
[not found] ` <49E47C2D.1050508-fPLkHRcR87vqlBn2x/YWAg@public.gmane.org>
2009-04-15 10:26 ` panic on rmmod of nf_conntrack_irc Patrick McHardy
2009-04-15 10:42 ` Eric Dumazet
2009-04-15 10:44 ` Patrick McHardy
2009-04-15 10:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E47EA5.3060706@trash.net \
--to=kaber@trash.net \
--cc=dada1@cosmosbay.com \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).