From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: panic on rmmod of nf_conntrack_irc Date: Tue, 14 Apr 2009 14:16:37 +0200 Message-ID: <49E47EA5.3060706@trash.net> References: <20090410191736.21efab8c@mako-desktop> <49E4744D.5090205@trash.net> <49E47C2D.1050508@cosmosbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Mariusz Kozlowski , Kernel Testers List , "linux-kernel@vger.kernel.org" , Netfilter Development Mailinglist , Linux Netdev List To: Eric Dumazet Return-path: Received: from stinky.trash.net ([213.144.137.162]:61757 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752436AbZDNMQs (ORCPT ); Tue, 14 Apr 2009 08:16:48 -0400 In-Reply-To: <49E47C2D.1050508@cosmosbay.com> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Eric Dumazet wrote: > Patrick McHardy a =E9crit : >> Mariusz Kozlowski wrote: >>> netfilter: nf_conntrack: use SLAB_DESTROY_BY_RCU and get rid of >>> call_rcu() >> Thanks for the report. Does this patch fix it? >> >=20 > Hi Patrick, sorry for the delay, I was in holidays. No problem, me too :) > I should have used different fields names (from "next", "first", ...)= to catch this > kind of errors at compile time :( > > Something like : Thanks Eric. I guess at this point it doesn't really matter anymore for the upstream kernel, but I'll apply your patch after getting confirmation from Mariusz to make sure that people maintaining external patches will notice the change (and won't send me broken patches :)). -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html