From: Patrick McHardy <kaber@trash.net>
To: Saikiran Madugula <hummerbliss@gmail.com>
Cc: netdev <netdev@vger.kernel.org>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] Allow fragmentation of VLAN packets traversing a bridge.
Date: Fri, 17 Apr 2009 19:20:40 +0200 [thread overview]
Message-ID: <49E8BA68.50605@trash.net> (raw)
In-Reply-To: <49E8B73C.7080004@gmail.com>
Saikiran Madugula wrote:
> Patrick McHardy wrote:
>>> - if (skb->protocol == htons(ETH_P_IP) &&
>>> + if ((skb->protocol == htons(ETH_P_IP) || IS_VLAN_IP(skb)) &&
>>> skb->len > skb->dev->mtu &&
>>> !skb_is_gso(skb))
>>> return ip_fragment(skb, br_dev_queue_push_xmit);
>> Please add an additional check for skb->nfct != NULL to make sure
>> that this only refragments packets defragmented by conntrack.
>
> Thanks for the feedback, skb->nfct is present only if CONFIG_NF_CONNTRACK or
> CONFIG_NF_CONNTRACK_MODULE is defined. Was wondering if the entire check before
> ip_fragment is necessary if NF_CONNTRACK is not defined. If not, I will post
> updated patch as per your suggestion.
Good point. Yes, everything related to fragmenting is only needed
with NF_CONNTRACK, so an additional ifdef makes sense.
next prev parent reply other threads:[~2009-04-17 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 15:19 [PATCH] Allow fragmentation of VLAN packets traversing a bridge Saikiran Madugula
2009-04-17 15:57 ` Patrick McHardy
2009-04-17 17:07 ` Saikiran Madugula
2009-04-17 17:20 ` Patrick McHardy [this message]
2009-04-17 22:51 ` Saikiran Madugula
2009-04-20 15:13 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E8BA68.50605@trash.net \
--to=kaber@trash.net \
--cc=hummerbliss@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).