From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
netfilter-devel@vger.kernel.org
Subject: Re: netfilter conntrack tcp lock
Date: Wed, 22 Apr 2009 18:04:20 +0200 [thread overview]
Message-ID: <49EF4004.6040303@trash.net> (raw)
In-Reply-To: <49EEA3B1.9030803@cosmosbay.com>
Eric Dumazet wrote:
> Stephen Hemminger a écrit :
>> Not sure what the performance impact would be but simply changing tcp_lock
>> (in nf_conntrack_proto_tcp) to a spin_lock might get a performance boost.
>> I thought I heard Paul say read_locks are way slower than spin_lock.
>>
>> Alternatively, going to some form of bit based hash lock might work.
>>
> I thought Patrick was OK with adding a spinlock into each nf_conn struct ?
> (We shrunk this struct with the rcu_head removal)
Yes, my main concern was the further size increase.
> A straight forward locking schem. We have spinlocks everywhere in kernel afterall, and
> conntracking deserves this.
>
> Just resubmit one of your prior patch perhaps ? I can dig it in a couple of hours eventually.
Yes, please.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-04-22 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090421210412.268fc4e7@nehalam>
2009-04-22 4:20 ` netfilter conntrack tcp lock Paul E. McKenney
2009-04-22 4:57 ` Eric Dumazet
2009-04-22 16:04 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EF4004.6040303@trash.net \
--to=kaber@trash.net \
--cc=dada1@cosmosbay.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).