* nf_conntrack_proto_udplite
@ 2009-04-22 20:06 Steven Jan Springl
2009-04-23 10:30 ` nf_conntrack_proto_udplite Patrick McHardy
0 siblings, 1 reply; 5+ messages in thread
From: Steven Jan Springl @ 2009-04-22 20:06 UTC (permalink / raw)
To: netfilter-devel
Hello
Whilst testing kernel 2.6.30-rc3 I have noticed that when I issue command:
modprobe nf_conntrack_proto_udplite
the following message is produced:
FATAL: Error inserting nf_conntrack_proto_udplite
(/lib/modules/2.6.30-rc3/kernel/net/netfilter/nf_conntrack_proto_udplite.ko):
Invalid argument
Is this a kernel bug or have I done something wrong?
Steven.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nf_conntrack_proto_udplite
2009-04-22 20:06 nf_conntrack_proto_udplite Steven Jan Springl
@ 2009-04-23 10:30 ` Patrick McHardy
2009-04-23 14:25 ` nf_conntrack_proto_udplite Steven Jan Springl
0 siblings, 1 reply; 5+ messages in thread
From: Patrick McHardy @ 2009-04-23 10:30 UTC (permalink / raw)
To: Steven Jan Springl; +Cc: netfilter-devel
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
Steven Jan Springl wrote:
> Hello
>
> Whilst testing kernel 2.6.30-rc3 I have noticed that when I issue command:
>
> modprobe nf_conntrack_proto_udplite
>
> the following message is produced:
>
> FATAL: Error inserting nf_conntrack_proto_udplite
> (/lib/modules/2.6.30-rc3/kernel/net/netfilter/nf_conntrack_proto_udplite.ko):
> Invalid argument
>
> Is this a kernel bug or have I done something wrong?
Thanks for the report, it seems the IPv6 udplite protocol was
forgotten during a recent API change.
Does this patch help?
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 632 bytes --]
diff --git a/net/netfilter/nf_conntrack_proto_udplite.c b/net/netfilter/nf_conntrack_proto_udplite.c
index 4614696..0badedc 100644
--- a/net/netfilter/nf_conntrack_proto_udplite.c
+++ b/net/netfilter/nf_conntrack_proto_udplite.c
@@ -204,6 +204,7 @@ static struct nf_conntrack_l4proto nf_conntrack_l4proto_udplite6 __read_mostly =
.error = udplite_error,
#if defined(CONFIG_NF_CT_NETLINK) || defined(CONFIG_NF_CT_NETLINK_MODULE)
.tuple_to_nlattr = nf_ct_port_tuple_to_nlattr,
+ .nlattr_tuple_size = nf_ct_port_nlattr_tuple_size,
.nlattr_to_tuple = nf_ct_port_nlattr_to_tuple,
.nla_policy = nf_ct_port_nla_policy,
#endif
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: nf_conntrack_proto_udplite
2009-04-23 10:30 ` nf_conntrack_proto_udplite Patrick McHardy
@ 2009-04-23 14:25 ` Steven Jan Springl
2009-04-23 22:24 ` nf_conntrack_proto_udplite Pablo Neira Ayuso
0 siblings, 1 reply; 5+ messages in thread
From: Steven Jan Springl @ 2009-04-23 14:25 UTC (permalink / raw)
To: Patrick McHardy; +Cc: netfilter-devel
On Thursday 23 April 2009 11:30:12 Patrick McHardy wrote:
> Steven Jan Springl wrote:
> > Hello
> >
> > Whilst testing kernel 2.6.30-rc3 I have noticed that when I issue
> > command:
> >
> > modprobe nf_conntrack_proto_udplite
> >
> > the following message is produced:
> >
> > FATAL: Error inserting nf_conntrack_proto_udplite
> > (/lib/modules/2.6.30-rc3/kernel/net/netfilter/nf_conntrack_proto_udplite.
> >ko): Invalid argument
> >
> > Is this a kernel bug or have I done something wrong?
>
> Thanks for the report, it seems the IPv6 udplite protocol was
> forgotten during a recent API change.
>
> Does this patch help?
Patrick
The patch has fixed the problem. Thank you.
Steven.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nf_conntrack_proto_udplite
2009-04-23 14:25 ` nf_conntrack_proto_udplite Steven Jan Springl
@ 2009-04-23 22:24 ` Pablo Neira Ayuso
2009-04-24 13:02 ` nf_conntrack_proto_udplite Patrick McHardy
0 siblings, 1 reply; 5+ messages in thread
From: Pablo Neira Ayuso @ 2009-04-23 22:24 UTC (permalink / raw)
To: Patrick McHardy; +Cc: Steven Jan Springl, netfilter-devel
Hi Patrick,
Steven Jan Springl wrote:
> On Thursday 23 April 2009 11:30:12 Patrick McHardy wrote:
>> Steven Jan Springl wrote:
>>> Hello
>>>
>>> Whilst testing kernel 2.6.30-rc3 I have noticed that when I issue
>>> command:
>>>
>>> modprobe nf_conntrack_proto_udplite
>>>
>>> the following message is produced:
>>>
>>> FATAL: Error inserting nf_conntrack_proto_udplite
>>> (/lib/modules/2.6.30-rc3/kernel/net/netfilter/nf_conntrack_proto_udplite.
>>> ko): Invalid argument
>>>
>>> Is this a kernel bug or have I done something wrong?
>> Thanks for the report, it seems the IPv6 udplite protocol was
>> forgotten during a recent API change.
>>
>> Does this patch help?
We also need it for DCCP. I'm going to send another patch for it.
--
"Los honestos son inadaptados sociales" -- Les Luthiers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nf_conntrack_proto_udplite
2009-04-23 22:24 ` nf_conntrack_proto_udplite Pablo Neira Ayuso
@ 2009-04-24 13:02 ` Patrick McHardy
0 siblings, 0 replies; 5+ messages in thread
From: Patrick McHardy @ 2009-04-24 13:02 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Steven Jan Springl, netfilter-devel
Pablo Neira Ayuso wrote:
> Hi Patrick,
>
> Steven Jan Springl wrote:
>> On Thursday 23 April 2009 11:30:12 Patrick McHardy wrote:
>>> Thanks for the report, it seems the IPv6 udplite protocol was
>>> forgotten during a recent API change.
>>>
>>> Does this patch help?
>
> We also need it for DCCP. I'm going to send another patch for it.
I already noticed and fixed it as well, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-04-24 13:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-22 20:06 nf_conntrack_proto_udplite Steven Jan Springl
2009-04-23 10:30 ` nf_conntrack_proto_udplite Patrick McHardy
2009-04-23 14:25 ` nf_conntrack_proto_udplite Steven Jan Springl
2009-04-23 22:24 ` nf_conntrack_proto_udplite Pablo Neira Ayuso
2009-04-24 13:02 ` nf_conntrack_proto_udplite Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).