From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, mingo@elte.hu,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
davem@davemloft.net, dada1@cosmosbay.com, zbr@ioremap.net,
jeff.chua.linux@gmail.com, paulus@samba.org, jengelh@medozas.de,
r000n@r000n.net, benh@kernel.crashing.org,
mathieu.desnoyers@polymtl.ca
Subject: Re: [PATCH RFC] v5 expedited "big hammer" RCU grace periods
Date: Mon, 18 May 2009 14:59:52 +0800 [thread overview]
Message-ID: <4A110768.2040707@cn.fujitsu.com> (raw)
In-Reply-To: <20090517191141.GA25915@linux.vnet.ibm.com>
Paul E. McKenney wrote:
> +void sched_expedited_wake(void *unused)
> +{
> + mutex_lock(&__get_cpu_var(sched_expedited_done_mutex));
> + if (__get_cpu_var(sched_expedited_done_qs) ==
> + SCHED_EXPEDITED_QS_DONE_QS) {
> + __get_cpu_var(sched_expedited_done_qs) =
> + SCHED_EXPEDITED_QS_NEED_QS;
> + wake_up(&__get_cpu_var(sched_expedited_qs_wq));
> + }
> + mutex_unlock(&__get_cpu_var(sched_expedited_done_mutex));
> +}
[...]
> + get_online_cpus();
> + preempt_disable();
> + mycpu = smp_processor_id();
> + smp_call_function(sched_expedited_wake, NULL, 1);
sched_expedited_wake() calls mutex_lock() which may sleep?
And I think you have re-implement workqueue.
Thanks, Lai.
next prev parent reply other threads:[~2009-05-18 7:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-17 19:11 [PATCH RFC] v5 expedited "big hammer" RCU grace periods Paul E. McKenney
2009-05-17 20:02 ` Evgeniy Polyakov
2009-05-17 22:08 ` Paul E. McKenney
2009-05-18 6:59 ` Lai Jiangshan [this message]
2009-05-18 14:40 ` Paul E. McKenney
2009-05-18 7:56 ` Ingo Molnar
2009-05-18 15:14 ` Paul E. McKenney
2009-05-18 15:42 ` Ingo Molnar
2009-05-18 16:02 ` Paul E. McKenney
2009-05-19 8:58 ` Ingo Molnar
2009-05-19 12:33 ` Paul E. McKenney
2009-05-19 12:44 ` Ingo Molnar
2009-05-19 16:18 ` Paul E. McKenney
2009-05-20 8:09 ` Ingo Molnar
2009-05-20 15:30 ` Paul E. McKenney
2009-05-27 22:57 ` Ingo Molnar
2009-05-29 1:22 ` Paul E. McKenney
2009-05-29 12:06 ` Gautham R Shenoy
2009-05-30 4:56 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A110768.2040707@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=jeff.chua.linux@gmail.com \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=r000n@r000n.net \
--cc=torvalds@linux-foundation.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).