From: Patrick McHardy <kaber@trash.net>
To: Jesper Dangaard Brouer <hawk@comx.dk>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH 2/2] Bugfix: xt_hashlimit does a wrong SEQ_SKIP.
Date: Wed, 27 May 2009 15:46:46 +0200 [thread overview]
Message-ID: <4A1D4446.2060106@trash.net> (raw)
In-Reply-To: <20090526131857.7377.6946.stgit@localhost>
Jesper Dangaard Brouer wrote:
> (Inside net/netfilter/xt_hashlimit.c)
> The function dl_seq_show() returns 1 (equal to SEQ_SKIP) in case
> a seq_printf() call return -1. It should return -1.
>
> This SEQ_SKIP behavior brakes processing the proc file e.g. via a
> pipe or just through less.
Applied patch 2/2, thanks.
prev parent reply other threads:[~2009-05-27 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 13:18 [PATCH 1/2] Doc: seq_file.txt fix wrong dd command example Jesper Dangaard Brouer
2009-05-26 13:18 ` [PATCH 2/2] Bugfix: xt_hashlimit does a wrong SEQ_SKIP Jesper Dangaard Brouer
2009-05-27 13:46 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1D4446.2060106@trash.net \
--to=kaber@trash.net \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=hawk@comx.dk \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).