From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jan Kasprzak <kas@fi.muni.cz>, netfilter-devel@vger.kernel.org
Subject: Re: [RFD,patch] ICMP echo conntrack timeout
Date: Tue, 02 Jun 2009 14:48:59 +0200 [thread overview]
Message-ID: <4A251FBB.8060804@trash.net> (raw)
In-Reply-To: <4A251127.8000605@netfilter.org>
Pablo Neira Ayuso wrote:
>> I think it would be better to keep the default timeout of
>> nf_ct_icmp_timeout even after the echo reply is received. Feel free
>> to correct me why early deleting of ICMP conntrack entries is needed,
>> or consider applying the following patch.
>
> The only problem that I see is that you patch relaxes the current
> checking that we're doing. I mean, for every packet in one direction we
> only accept one ICMP reply packet. With your patch, we can accept more
> than one packet in the reply direction.
Thats the intention, isn't it? :) I don't see a problem with this,
conntrack is supposed to accept valid responses and I don't think
its unreasonable to consider duplicate echo-replies as valid.
next prev parent reply other threads:[~2009-06-02 12:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 17:43 [RFD,patch] ICMP echo conntrack timeout Jan Kasprzak
2009-06-02 11:46 ` Pablo Neira Ayuso
2009-06-02 12:47 ` Jan Kasprzak
2009-06-02 12:48 ` Patrick McHardy [this message]
2009-06-02 14:53 ` Pablo Neira Ayuso
2009-06-02 15:01 ` Patrick McHardy
2009-06-02 15:20 ` Pablo Neira Ayuso
2009-06-02 12:10 ` Patrick McHardy
2009-06-05 10:46 ` Patrick McHardy
2009-06-07 1:03 ` Jan Kasprzak
2009-06-08 13:54 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A251FBB.8060804@trash.net \
--to=kaber@trash.net \
--cc=kas@fi.muni.cz \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).