From: Laszlo Attila Toth <panther@balabit.hu>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, jengelh@medozas.de
Subject: Re: [resend net-next] socket: Added 'transparent' option
Date: Fri, 05 Jun 2009 15:06:59 +0200 [thread overview]
Message-ID: <4A291873.5080707@balabit.hu> (raw)
In-Reply-To: <4A27CD5A.6040303@trash.net>
Patrick McHardy wrote:
> Laszlo Attila Toth wrote:
>> nf_tproxy_put_sock(sk);
>> +
>> if (wildcard)
>> sk = NULL;
>> + else if (check_transparent && info->transparent &&
>> + !transparent)
>> + sk = NULL;
>
> Please add a comment what this is doing exactly. And why do the lookup
> at all in this case?
>
We need a socket lookup because without it we can't know the listening
address and the socket's transparent state (socket option). After all of
these pieces of information is gathered, the socket can be put back.
--
Attila
next prev parent reply other threads:[~2009-06-05 13:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 13:26 [resend net-next] socket: Added 'transparent' option Laszlo Attila Toth
2009-06-04 13:26 ` [resend iptables] " Laszlo Attila Toth
2009-06-04 13:34 ` [resend net-next] " Patrick McHardy
2009-06-04 14:55 ` Jan Engelhardt
2009-06-04 15:27 ` Laszlo Attila Toth
2009-06-04 16:03 ` Jan Engelhardt
2009-06-04 16:08 ` Patrick McHardy
2009-06-05 13:06 ` Laszlo Attila Toth [this message]
2009-06-08 12:30 ` [resend2] Socket match with transparent option, take 2 Laszlo Attila Toth
2009-06-08 12:30 ` [resend2 net-next] socket: added mtinfo with 'transparent' flag Laszlo Attila Toth
2009-06-08 12:30 ` [resend2 iptables] socket match: new revision, match transparent sockets Laszlo Attila Toth
2009-06-09 12:50 ` [resend2 net-next] socket: added mtinfo with 'transparent' flag Patrick McHardy
2009-06-09 13:11 ` [net-next] " Laszlo Attila Toth
2009-06-09 13:18 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A291873.5080707@balabit.hu \
--to=panther@balabit.hu \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).