netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: sachin sanap <sachin.sanap.1gb@gmail.com>,
	Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>,
	buytenh@wantstofly.org, Bart De Schuymer <bdschuym@pandora.be>
Subject: Re: ebtables broken for kernel above 2.6.28
Date: Fri, 05 Jun 2009 15:38:48 +0200	[thread overview]
Message-ID: <4A291FE8.1040708@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.00.0906051531290.7950@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On 2009-06-02 12:20:45, Patrick McHardy wrote:
>   
>> On Friday 2009-05-29 19:16, Jan Engelhardt wrote:
>>     
>>> On Friday 2009-05-29 18:20, Bart De Schuymer wrote:
>>>       
>>>> I think it's best to fix this in the kernel if it's possible,
>>>> since we don't want to break compatibility. If the fix has to be
>>>> in userspace, then it must be a fix that still works for older
>>>> kernels.
>>>>
>>>> -#define EBT_MIN_ALIGN (__alignof__(struct ebt_entry_target))
>>>> +#define EBT_MIN_ALIGN (__alignof__(struct _xt_align))
>>>>         
>>> Since the kernel uses xt_align already, it's best for userspace to
>>> do the same.
>>>       
>> But that doesn't work for older kernels. Please don't dismiss
>> compatibility issues that easily. Sometimes things unfortunately do
>> slip through, but I expect people to do their best to fix the
>> problem properly when this happens.
>>     
>
> But if it gets changed back again to ebt_entry_target, it might
> stop working for the combinations it currently works on. :/
>   

Why, ebtables userspace didn't change, which implies it will still work?


  reply	other threads:[~2009-06-05 13:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <17923cc80905280124t4ed6cf7m87f91e4444146697@mail.gmail.com>
     [not found] ` <4A1EB783.4090801@pandora.be>
2009-05-29  5:51   ` Fwd: ebtables broken for kernel above 2.6.28 sachin sanap
2009-05-29 10:02     ` Jan Engelhardt
2009-05-29 11:14       ` sachin sanap
2009-05-29 16:20         ` Bart De Schuymer
2009-05-29 17:16           ` Jan Engelhardt
2009-06-02 12:20             ` Patrick McHardy
2009-06-05 13:35               ` Jan Engelhardt
2009-06-05 13:38                 ` Patrick McHardy [this message]
2009-06-14 17:42         ` Fwd: " Jan Engelhardt
2009-06-19  6:06           ` Sachin Sanap
2009-06-14 15:47     ` Peter Volkov
2009-06-14 16:54       ` Bart De Schuymer
2009-06-16 23:08 Jan Engelhardt
2009-06-18 16:33 ` Bart De Schuymer
2009-06-19  4:40   ` sachin sanap
2009-06-19  6:16   ` Sachin Sanap
2009-06-21 15:16   ` Bart De Schuymer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A291FE8.1040708@trash.net \
    --to=kaber@trash.net \
    --cc=bdschuym@pandora.be \
    --cc=buytenh@wantstofly.org \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=sachin.sanap.1gb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).