From: Tobias Klauser <klto@zhaw.ch>
To: Patrick McHardy <kaber@trash.net>
Cc: bart.de.schuymer@pandora.be, shemminger@linux-foundation.org,
davem@davemloft.net, ebtables-devel@lists.sourceforge.net,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netfilter: ebtables: Use print_mac instead of own function
Date: Thu, 16 Jul 2009 09:25:14 +0200 [thread overview]
Message-ID: <4A5ED5DA.303@zhaw.ch> (raw)
In-Reply-To: <4A5DF1FC.3050404@trash.net>
On 07/15/2009 05:13 PM, Patrick McHardy wrote:
> Tobias Klauser wrote:
>> ebt_log uses its own implementation of print_mac to print MAC addresses.
>> This patch converts it to use print_mac from linux/if_ether.h
>
> You can do this even simpler by using %pM as format string.
Sorry, I didn't know about that one. I'll send an updated patch.
Thanks for the hint.
Tobias
next prev parent reply other threads:[~2009-07-16 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 10:55 [PATCH] netfilter: ebtables: Use print_mac instead of own function Tobias Klauser
2009-07-15 15:13 ` Patrick McHardy
2009-07-16 7:25 ` Tobias Klauser [this message]
2009-07-16 7:25 ` [PATCH v2] netfilter: ebtables: Use %pM conversion specifier Tobias Klauser
2009-08-10 8:11 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5ED5DA.303@zhaw.ch \
--to=klto@zhaw.ch \
--cc=bart.de.schuymer@pandora.be \
--cc=davem@davemloft.net \
--cc=ebtables-devel@lists.sourceforge.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).