From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/4] length: support semi-infinite length description
Date: Thu, 20 Aug 2009 17:12:43 +0200 [thread overview]
Message-ID: <4A8D67EB.9080304@trash.net> (raw)
In-Reply-To: <1250780978-14013-2-git-send-email-jengelh@medozas.de>
Jan Engelhardt wrote:
> The code is already there, it just was not documented. Also use
> UINT16_MAX instead and pretty-print iptables's -L/-S output.
>
> @@ -97,9 +97,11 @@ length_print(const void *ip, const struct xt_entry_match *match, int numeric)
>
> printf("length %s", info->invert ? "!" : "");
> if (info->min == info->max)
> - printf("%u ", info->min);
> + printf("== %u ", info->min);
> + else if (info->max == UINT16_MAX)
> + printf(">= %u ", info->min);
> else
> - printf("%u:%u ", info->min, info->max);
> + printf("%u..%u ", info->min, info->max);
I prefer to keep using ":", this is what we use everywhere else for
ranges.
next prev parent reply other threads:[~2009-08-20 15:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 15:09 Manpage updates for iptables Jan Engelhardt
2009-08-20 15:09 ` [PATCH 1/4] length: support semi-infinite length description Jan Engelhardt
2009-08-20 15:12 ` Patrick McHardy [this message]
2009-08-20 15:16 ` Patrick McHardy
2009-08-20 15:09 ` [PATCH 2/4] ipt_set: fix a typo in the manpage Jan Engelhardt
2009-08-20 15:13 ` Patrick McHardy
2009-08-20 15:21 ` Jan Engelhardt
2009-08-20 15:31 ` Patrick McHardy
2009-08-20 16:47 ` Phil Oester
2009-08-24 12:19 ` Patrick McHardy
2009-08-20 15:09 ` [PATCH 3/4] manpage: fix lintian warnings Jan Engelhardt
2009-08-20 15:14 ` Patrick McHardy
2009-08-20 15:09 ` [PATCH 4/4] manpages: more fixes to minuses, hyphens, dashes Jan Engelhardt
2009-08-20 15:15 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8D67EB.9080304@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).