From: Bart De Schuymer <bdschuym@pandora.be>
To: Shai Tahar <shait@storwize.com>
Cc: netfilter-devel@vger.kernel.org, shai.tahar@storwize.com
Subject: Re: new target - ebtables dynamic snat, kernel and userspace patch
Date: Thu, 24 Sep 2009 22:24:17 +0200 [thread overview]
Message-ID: <4ABBD571.7050206@pandora.be> (raw)
In-Reply-To: <4ABB2336.6040806@storwize.com>
Shai Tahar schreef:
> ---- README ---
> ebt_dyn_snat - ebtable dynamic snat
> Authors:
> Shai Tahar <shai.tahar@storwize.com>
>
> Changes source mac address according to source ip address based on
> local arp table
> to be used when source ip address is snated
>
Hi,
A few comments/questions.
Why is the standard target DROP?
Please provide a man file entry (ebtables.8)
You didn't provide the configuration option for the kernel
Please provide the patches as attachments (separate files for kernel and
userspace) that will patch correctly with 'patch -p1 < $file'
After a first glance the code looks ok.
Maybe the description of your target should be more general: it matches
the ARP source address to the IP source address based on the local arp
table. Your target is indeed useful to make a bridging firewall that
does IP NAT more transparent.
cheers,
Bart
prev parent reply other threads:[~2009-09-24 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 7:43 new target - ebtables dynamic snat, kernel and userspace patch Shai Tahar
2009-09-24 8:12 ` Jan Engelhardt
2009-09-24 8:30 ` Shai Tahar
2009-09-24 11:26 ` Amos Jeffries
2009-09-25 1:04 ` Philip Craig
2009-09-24 20:24 ` Bart De Schuymer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABBD571.7050206@pandora.be \
--to=bdschuym@pandora.be \
--cc=netfilter-devel@vger.kernel.org \
--cc=shai.tahar@storwize.com \
--cc=shait@storwize.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).