From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: stomping static data pull Date: Thu, 29 Oct 2009 16:59:58 +0100 Message-ID: <4AE9BBFE.400@trash.net> References: <1255166535-6386-1-git-send-email-jengelh@medozas.de> <4AE869FB.1000506@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Jan Engelhardt Return-path: Received: from stinky.trash.net ([213.144.137.162]:53643 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752690AbZJ2QAC (ORCPT ); Thu, 29 Oct 2009 12:00:02 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jan Engelhardt wrote: > On Wednesday 2009-10-28 16:57, Patrick McHardy wrote: >> Jan Engelhardt wrote: >>> I incorporated your suggestions and propose this new 4-series set. >> Could you give me a short description of the changes relative >> to the first incarnation? Thanks. > > http://osdir.com/ml/general/2009-08/msg10540.html > - splitting xt_repldata_create > - giving it a name of your choice > - return semantics (found a missing return keyword; just refreshed top > is commit v2.6.32-rc3-4-g7891b6c) > OK thanks, that leaves my worries about adding additional runtime overhead. I'll do some quick benchmarks to see if it really has a measurable impact.