From: Patrick McHardy <kaber@trash.net>
To: xiaosuo@gmail.com
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nf_queue: Put devs after calling handler
Date: Fri, 20 Nov 2009 13:41:09 +0100 [thread overview]
Message-ID: <4B068E65.6050509@trash.net> (raw)
In-Reply-To: <4B05FEA0.402@gmail.com>
Changli Gao wrote:
> Put devs after calling handler.
>
> If we put the devs before calling handler, the devs may disappear when the handler is running.
>
> @@ -236,9 +231,6 @@ void nf_reinject(struct nf_queue_entry *entry, unsigned int verdict)
> const struct nf_afinfo *afinfo;
>
> rcu_read_lock();
> -
> - nf_queue_entry_release_refs(entry);
> -
The devices won't disappear under rcu_read_lock().
prev parent reply other threads:[~2009-11-20 12:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 2:27 [PATCH] nf_queue: Put devs after calling handler Changli Gao
2009-11-20 12:41 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B068E65.6050509@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).