From: Patrick McHardy <kaber@trash.net>
To: Changli Gao <xiaosuo@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nfnetlink_queue: Use hash to speed up finding entries in nfqueue
Date: Fri, 20 Nov 2009 14:56:32 +0100 [thread overview]
Message-ID: <4B06A010.4040506@trash.net> (raw)
In-Reply-To: <412e6f7f0911200546n5d44082dt69fec1514b51c12b@mail.gmail.com>
Changli Gao wrote:
> On Fri, Nov 20, 2009 at 9:12 PM, Patrick McHardy <kaber@trash.net> wrote:
>> Changli Gao wrote:
>>> Use hash to speed up finding entries in nfqueue.
>>>
>>> If user implements QoS in userland, packet verdict won't be received in order. At this moment, a hash table is faster than a double linked list when finding the corresponding entries in nfqueue.
>>>
>>> This patch also fixes a potential bug, which will allows more than one entries with the same id are in the same nfqueue in the extreme.
>> Instead of a double ID in a purely hypothetical case, we'd now
>> get an endless loop. This part doesn't make much sense to me,
>> please remove it from the patch.
>>
>
> It isn't a endless loop, as we limite the queue size.
It is if queue_maxlen is set to the maximum. In any case this change
adds a new lookup for ID assignment and complicates the code for a
case which I still consider purely hypothetical. Additionally it is
not related to the hashing change and shouldn't be in the same patch.
next prev parent reply other threads:[~2009-11-20 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 4:56 [PATCH] nfnetlink_queue: Use hash to speed up finding entries in nfqueue Changli Gao
2009-11-20 13:12 ` Patrick McHardy
2009-11-20 13:46 ` Changli Gao
2009-11-20 13:56 ` Patrick McHardy [this message]
2009-11-20 14:00 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B06A010.4040506@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).