From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Laurent Chavey <chavey@google.com>,
davem@davemloft.net, netdev@vger.kernel.org,
Patrick McHardy <kaber@trash.net>,
Netfilter Developers <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] netfilter: Fix compiler warning.
Date: Thu, 10 Dec 2009 20:31:52 +0100 [thread overview]
Message-ID: <4B214CA8.7010902@gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.01.0912101953360.23791@obet.zrqbmnf.qr>
Le 10/12/2009 19:53, Jan Engelhardt a écrit :
>
> On Donnerstag 2009-12-10 18:50, Laurent Chavey wrote:
>>
>> good point. I agree with the need for the exception, I would just
>> like it to be more explicit in the code itself (like a turn off
>> check around that particular statement) so we do not have to scrub
>> thru the compiler output to filter out good / bad warning. question:
>> why do we not force the timestamp in the skb before going thru the
>> chain ?
>
> Because it is probably too expensive to do, unless you employ
> things like xt_time?
Right. On some platforms, timestamps are quite expensive (say, a fraction
of one micro second to get one of them), we try to avoid them as much as possible.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-12-10 19:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <pvmhbrzboyb.fsf@chavey.mtv.corp.google.com>
2009-12-10 2:07 ` [PATCH] netfilter: Fix compiler warning David Miller
2009-12-10 4:25 ` Eric Dumazet
2009-12-10 11:26 ` Patrick McHardy
2009-12-10 17:50 ` Laurent Chavey
2009-12-10 18:53 ` Jan Engelhardt
2009-12-10 19:31 ` Eric Dumazet [this message]
2009-12-10 21:44 chavey
2009-12-10 22:06 ` Jan Engelhardt
2009-12-10 22:08 ` David Miller
2009-12-10 23:23 ` Jan Engelhardt
2009-12-10 23:44 ` Jan Engelhardt
2009-12-14 13:20 ` Patrick McHardy
2009-12-10 22:13 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B214CA8.7010902@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=chavey@google.com \
--cc=davem@davemloft.net \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).