From: Patrick McHardy <kaber@trash.net>
To: Simon Horman <horms@verge.net.au>
Cc: lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org, Deon van der Merwe <dvdm@truteq.co.za>,
Wensong Zhang <wensong@linux-vs.org>,
Julian Anastasov <ja@ssi.bg>, David Miller <davem@davemloft.org>
Subject: Re: [patch] ipvs: zero usvc and udest
Date: Tue, 15 Dec 2009 17:02:37 +0100 [thread overview]
Message-ID: <4B27B31D.3050207@trash.net> (raw)
In-Reply-To: <20091214223902.GA3784@verge.net.au>
Simon Horman wrote:
> Make sure that any otherwise uninitialised fields of usvc are zero.
>
> This has been obvserved to cause a problem whereby the port of
> fwmark services may end up as a non-zero value which causes
> scheduling of a destination server to fail for persisitent services.
>
> As observed by Deon van der Merwe <dvdm@truteq.co.za>.
> This fix suggested by Julian Anastasov <ja@ssi.bg>.
>
> For good measure also zero udest.
>
> Cc: Deon van der Merwe <dvdm@truteq.co.za>
> Acked-by: Julian Anastasov <ja@ssi.bg>
> Signed-off-by: Simon Horman <horms@verge.net.au>
>
> ---
>
> This bug has been present since the netlink interface to IPVS was
> introduced in 2.6.28. I think it is relevant for 2.6.33 as well
> as -stable.
Applied, thanks. I'll push it to -stable as well.
prev parent reply other threads:[~2009-12-15 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 22:39 [patch] ipvs: zero usvc and udest Simon Horman
2009-12-15 16:02 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B27B31D.3050207@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.org \
--cc=dvdm@truteq.co.za \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).