* [PATCH] netfilter: simplify warning message
@ 2010-01-15 22:05 Eric Leblond
2010-01-18 7:53 ` Patrick McHardy
0 siblings, 1 reply; 4+ messages in thread
From: Eric Leblond @ 2010-01-15 22:05 UTC (permalink / raw)
To: Patrick McHardy; +Cc: netfilter-devel, Eric Leblond
This patch remove variable part from a debug message to have
message concatenation from syslog.
---
net/netfilter/nfnetlink_queue.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
index 7e3fa41..b5ed1f7 100644
--- a/net/netfilter/nfnetlink_queue.c
+++ b/net/netfilter/nfnetlink_queue.c
@@ -414,8 +414,8 @@ nfqnl_enqueue_packet(struct nf_queue_entry *entry, unsigned int queuenum)
queue->queue_dropped++;
if (net_ratelimit())
printk(KERN_WARNING "nf_queue: full at %d entries, "
- "dropping packets(s). Dropped: %d\n",
- queue->queue_total, queue->queue_dropped);
+ "dropping packets(s).\n",
+ queue->queue_total);
goto err_out_free_nskb;
}
--
1.6.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] netfilter: simplify warning message
2010-01-15 22:05 [PATCH] netfilter: simplify warning message Eric Leblond
@ 2010-01-18 7:53 ` Patrick McHardy
2010-01-18 8:42 ` Eric Leblond
0 siblings, 1 reply; 4+ messages in thread
From: Patrick McHardy @ 2010-01-18 7:53 UTC (permalink / raw)
To: Eric Leblond; +Cc: netfilter-devel
Eric Leblond wrote:
> This patch remove variable part from a debug message to have
> message concatenation from syslog.
It also makes the message less informative, but OK, this information
is not particulary important and available through proc anyways.
But I do need a Signed-off-by: line :)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] netfilter: simplify warning message
2010-01-18 7:53 ` Patrick McHardy
@ 2010-01-18 8:42 ` Eric Leblond
2010-01-18 8:45 ` Patrick McHardy
0 siblings, 1 reply; 4+ messages in thread
From: Eric Leblond @ 2010-01-18 8:42 UTC (permalink / raw)
To: Patrick McHardy; +Cc: netfilter-devel, Eric Leblond
This patch remove variable part from a debug message to have
message concatenation from syslog.
Signed-off-by: Eric Leblond <eric@inl.fr>
---
net/netfilter/nfnetlink_queue.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
index 7e3fa41..b5ed1f7 100644
--- a/net/netfilter/nfnetlink_queue.c
+++ b/net/netfilter/nfnetlink_queue.c
@@ -414,8 +414,8 @@ nfqnl_enqueue_packet(struct nf_queue_entry *entry, unsigned int queuenum)
queue->queue_dropped++;
if (net_ratelimit())
printk(KERN_WARNING "nf_queue: full at %d entries, "
- "dropping packets(s). Dropped: %d\n",
- queue->queue_total, queue->queue_dropped);
+ "dropping packets(s).\n",
+ queue->queue_total);
goto err_out_free_nskb;
}
--
1.6.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] netfilter: simplify warning message
2010-01-18 8:42 ` Eric Leblond
@ 2010-01-18 8:45 ` Patrick McHardy
0 siblings, 0 replies; 4+ messages in thread
From: Patrick McHardy @ 2010-01-18 8:45 UTC (permalink / raw)
To: Eric Leblond; +Cc: netfilter-devel
Eric Leblond wrote:
> This patch remove variable part from a debug message to have
> message concatenation from syslog.
>
> Signed-off-by: Eric Leblond <eric@inl.fr>
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-18 8:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-15 22:05 [PATCH] netfilter: simplify warning message Eric Leblond
2010-01-18 7:53 ` Patrick McHardy
2010-01-18 8:42 ` Eric Leblond
2010-01-18 8:45 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).